Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve duplicated GCS reactions #538

Merged
merged 8 commits into from
Apr 23, 2023

Conversation

haowang-bioinfo
Copy link
Member

@haowang-bioinfo haowang-bioinfo commented Apr 20, 2023

Main improvements in this PR:

This PR resolves duplicated reactions reported in #524, specifically for the glycine cleavage system (GCS):

  • remove lower resolution reaction MAR03923
  • remove high resolution set, MAR08435 + MAR08436 + MAR08437, due to the use of generic metabolite, e.g. lipoylprotein (MAM02400m)
  • remove generic metabolites lipoylprotein (MAM02400m), S-aminomethyldihydrolipoylprotein (MAM02879m), dihydrolipoylprotein (MAM01703m)
  • reduce MAR08433 and MAR08434 GPRs to specific components:
    • MAR08433: ENSG00000178445 and ENSG00000140905
    • MAR08434: ENSG00000140905 and ENSG00000145020

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch
  • Any removed reactions and metabolites have been moved to the corresponding deprecated identifier lists

Copy link
Collaborator

@feiranl feiranl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

- MAR08433: ENSG00000178445 and ENSG00000140905
- MAR08434: ENSG00000140905 and ENSG00000145020
@haowang-bioinfo haowang-bioinfo merged commit 981b6fc into develop Apr 23, 2023
@haowang-bioinfo haowang-bioinfo deleted the fix/resolveDuplicateGCSreactions branch April 23, 2023 21:08
@haowang-bioinfo haowang-bioinfo mentioned this pull request May 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants