-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: change multiple compartment abbreviations #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not know all your code and files but the ones I know look OK
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's neat!
Just so you know, there is a reference to 'x'
in a commented line in importYaml
, which might be good to either update or delete.
@mihai-sysbio Good catch, I have now removed that line. |
I've gone through all the changes that look good to me. @JonathanRob nice work. though there's a little concern about commit 5e6af0f that marked all these previous metabolite ids as deprecated, this is probably overkill. What we are trying to do here is replacing ids i.e. adapting to the BiGG (or KBase/SEED) scheme (#314), which actually reserved |
now the changes introduced by #339 led to conflicts in |
It looks to me like we are following the BiGG specification here, but maybe we should reference the source directly.
|
Just a ping to advance this PR. |
Once #343 is merged, the conflicts should be resolved. |
To avoid future merge conflicts, I think it makes sense to hold off on creating any PRs until the metabolites get renamed. This makes the current PR a priority. @JonathanRob let me know how I can help. |
@mihai-sysbio yes, exactly. I will merge #343 to see if that solves the conflict on this PR. If that doesn't work, then I may ask for some help. |
@mihai-sysbio sorry I missed this message |
Main improvements in this PR:
This is a more extensive/exhaustive implementation of #330 to address discussions in #314.
Three Human-GEM compartment abbreviations are changed in the model file, metabolite annotation file, metabolic task files, and the
addBoundaryMets
function:s
e
x
b
p
x
Since the changes (diffs) are quite large, I implemented the changes with a script
changeCompAbbrevs
incode/modelCuration/
.I hereby confirm that I have:
develop
as a target branch