-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Human 1.7 #247
Merged
Merged
Human 1.7 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rename functions as such: - importHumanYaml --> importYaml - writeHumanYaml --> exportYaml - these names were also changes in following functions: increaseHumanGEMVersion, exportHumanGEM, and testYamlConversion.
- `devel` --> `develop`
`devel` --> `develop`
`devel` --> `develop`
style: rename functions
…system-name fix: remove the extra space at the end of the subsystem and reaction names
This reverts commit 64566f3.
Update position, remove broken link
Move deprecated data and code to new .deprecated directory
The Rhea IDs obtain using UniProt were only Rhea master IDs (undirected reactions). Here the corresponding IDs for bidirectional reactions were automatically updated, and the corresponding IDs for directed reactions were manually curated.
Rhea annotations
- the code for completing MA rxn ids is included as well
feat: add MA met ids to metabolites.tsv
mihai-sysbio
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
JonathanRob
approved these changes
Apr 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main improvements in this PR:
metMAID
is added tometabolites.tsv
, according to the plan proposed in feat: new sets of id for reactions and metabolites #174reactions.tsv
by adding associations toRhea
ids that mapped to 590 rxns so farm01778
andm02646
, as suggested in Pubchem compound id duplicated/wrong #239:evalGeneEssentialityPred
that can be used to assess gene essentiality predictions made by a GEMrxnMAID
inreactions.tsv
by filling blank fields, as agreed in feat: new sets of id for reactions and metabolites #174annotateModel
-->annotateGEM
importHumanYaml
-->importYaml
writeHumanYaml
-->exportYaml
devel
withdevelop
data/
andcode/
that are no longer maintained or in use to a.deprecated
folderdata
andcode
directories