Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove the extra space at the end of the subsystem and reaction names #230

Conversation

mihai-sysbio
Copy link
Member

Main improvements in this PR:

There subsystem Cholesterol biosynthesis 1 (Bloch pathway) had an extra space at the end, which resulted in an error when deploying on Metabolic Atlas. Seeing no other confli

I hereby confirm that I have:

  • Tested my code on my own computer for running the model
  • Selected develop as a target branch

@haowang-bioinfo
Copy link
Member

@mihai-sysbio looks good. Please check all subsystems and remove any leading and trailing spaces in this PR.

@mihai-sysbio
Copy link
Member Author

Alright, I removed all cases when there was a space just before the end quotes.

@haowang-bioinfo
Copy link
Member

Super

@mihai-sysbio
Copy link
Member Author

I was going through the changes and noticed the last oneHMR_10046 has an incomplete name.

@haowang-bioinfo
Copy link
Member

The name of HMR_10046 should be 1,2-diacylglycerol-LD-PC pool transport(Cytosol to Extracellular).

@haowang-bioinfo haowang-bioinfo changed the title fix: remove the extra space at the end of the subsystem name fix: remove the extra space at the end of the subsystem names Feb 9, 2021
@mihai-sysbio mihai-sysbio changed the title fix: remove the extra space at the end of the subsystem names fix: remove the extra space at the end of the subsystem and reaction names Feb 9, 2021
@haowang-bioinfo haowang-bioinfo merged commit fc77dba into SysBioChalmers:develop Feb 9, 2021
@mihai-sysbio mihai-sysbio deleted the fix/rm-extra-space-in-subsystem-name branch February 9, 2021 15:18
@haowang-bioinfo haowang-bioinfo mentioned this pull request Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants