Transmission DSM7 support #4719

publicarray · 2021-07-08T06:16:29Z

Motivation: share worker supported since 6.0-5914
Linked issues: #4562 closes #4313

Checklist

Build rule all-supported completed successfully
Package upgrade completed successfully (dsm 6 & 7 individually) some users report a leftover firewall rule Can‘t start transmission on DSM7.0 #4313
New installation of package completed successfully (dsm6 & 7)

mreid-tt · 2021-08-07T10:43:40Z

great to see the work to bring this package to DSM7. looking forward to its release

publicarray · 2021-08-17T11:32:13Z

@hgy59 I've added the ability to have DSM version specific wizard files. (still needs French translation)
@BenjV already tested new installation procedure of the DSM7 package.

Selenuix · 2021-08-17T15:51:37Z

@hgy59 I've added the ability to have DSM version specific wizard files. (still needs French translation)
@BenjV already tested new installation procedure of the DSM7 package.

Are the translations still needed? Do you accept PRs? I got no real way to test but I could always try to help.

publicarray · 2021-08-19T22:56:35Z

Bonjour @Selenuix, PRs are always welcome. The Wizards are in a JSON format you can see the old translation I removed here fb8640d and the new ones can be found here https://github.com/SynoCommunity/spksrc/pull/4719/files#diff-10ef7b0d6d3b7deeb475da37e2b322ab6bdbaa8807b1146be0a9e531351fedf9

You can copy the contents into a new file appending the _fre to the file name. Mostly only the description needs translation. Any help is appreciated.

set using SERVICE_WIZARD_SHARE only disadvantage is that this does not support sub-folders currently [Transmission] fix empty volume, consistency with naming

* Remove busybox dep * transmission: remove unnecessary GROUP setting from service-setup.sh * transmission: set GROUP for backwards compatibility * Undo SPK_REV/CHANGELOG * Adjust wizard text * Remove now superfluous busybox configs

useful when using `synopkg install`

folders for DSM7

hgy59 · 2021-08-28T15:59:13Z

spk/transmission/src/service-setup.sh

 # This gives tranmission the power to execute python scripts on completion (like TorrentToMedia).
 PYTHON_DIR="/usr/local/python"
 PATH="${SYNOPKG_PKGDEST}/bin:${PYTHON_DIR}/bin:${PATH}"


As there is no SPK_DEPENDS=python... in this package, it is not defined which python should be used.

For synocommunity packages the path /usr/local/{package} must not be used anymore, i.e. it must be defined as /var/packages/{package}/target.

I suppose that python2 should not be used anymore, so the package must be python3 or python38.

Proposal:
remove these lines and rely on python that is already installed and available in the path.

if no python is found in path, a lookup for synocommunity python3 and python38 could be used here to add it to the path for transmission.

Thanks. Good catch! I didn't even notice that python can be used from transmission.

As of DSM 7, Python 3 is standard available and can be found via the path.

if no python is found in path, a lookup for synocommunity python3 and python38 could be used here to add it to the path for transmission.

@hgy59 I didn't do any fancy detection because that is what $PATH is for anyway. Don't need to do it twice and this way it still works if a python package is added or removed. Agreed, for DSM7 the build in Python should be good enough.

hgy59 · 2021-08-31T06:48:24Z

Can we now use spk/transmission as a template for wizard files with shared folders compatible with DSM 7?
This would help to finalize #4683, #4627 and all the download related packages like #4743 and others.

Zigwan06 · 2021-08-31T13:18:29Z

thank you for your work

BenjV · 2021-08-31T13:52:24Z

@hgy59 , @publicarray
I would suggest to use it for all packages, but at least not only for packages that create shared folders but also the ones who must read them.
Like Sonarr, Radarr and Sick(beard/chill) that reads files from the shares created by Nzbget and/or Transmission.
Their user should also be member of the syncommunity group.

So I would suggest to make all packages use the syncommunity group and not sc-packagename to keep things simple.

spyrodragon1 · 2021-08-31T18:30:40Z

Thanks for the work on this one. Just curious when the transmission update package actually be released via the synology apps section ? Thanks again.

publicarray · 2021-09-01T00:15:01Z

@hgy59 Yes we can. #4748 is interesting because I want to know what happens when multiple packages use the same shared folder. For DSM6 It also uses the old behaviour of creating shared folders. So existing DSM6 packages should continue to work. (sorry about the reverts I'm a bit indecisive)

@BenjV

shared folders but also the ones who must read them.

I'm not sure on that. Everyone has a different way to organise their media. e.g. filebot for instance. Setting up the permissions for the packages that you use is easy enough already. I prefer users to be educated rather than forcing a specific way of doing things. IMHO we should be phasing out wizards not add more.

all packages use the syncommunity group

You already convinced me see #4789

@spyrodragon1 tops 48h for the CDN to catch up

mreid-tt · 2021-09-01T00:54:14Z

was able to repair my transmission package successfully with this and it even retained all my previous torrents. great work folks!

gemmmo · 2021-09-01T01:52:06Z

Just updated DS218 (rtd1296) to DSM7. Repair didn't work in Package Manager but manual install of the package from the synocommunity website completed without errors and everything works fine. Thank you!

isr25 · 2021-09-01T03:09:03Z

Thank you for your hard work!

gemmmo · 2021-09-01T05:33:53Z

Not sure if this is the right place to ask, after installing transmission on DSM7 it shows up in Package Center and works when launched using the URL but there is no app shortcut in the main menu. Is there a way to fix this? For example if I uninstall Transmission and reinstall transmission will my torrent data be automatically restored? Thank you.

BenjV · 2021-09-01T07:53:15Z

Yes if you uninstall Transmission and do not remove the data you can install Transmission again and all torrents will be restored.

gemmmo · 2021-09-01T10:06:23Z

Yes if you uninstall Transmission and do not remove the data you can install Transmission again and all torrents will be restored.

Thanks for the help! Reinstalled smoothly but the Transmission logo still doesn't show up in the Main Menu. I'll leave it since it works fine launching from URL and the migration was perfect from DSM7.

BenjV · 2021-09-01T11:33:42Z

I have experienced that with more packages(also on DSM 6) and sometimes it just re-appears again and sometimes not.
Has noting to do with this package, maybe a reboot of your Nas will help.

gemmmo · 2021-09-01T12:13:15Z

So far rebooting hasn't worked yet but I will see how it goes. Transmission is working great regardless, thank you for the help!

spyrodragon1 · 2021-09-02T13:27:05Z

Apologies for the stupid question but do i need to update to v7 of the synology software to see the transmission update or should i see it while I'm on v6 ? The update hasn't appeared in the package center yet on my NAS and I'm just wondering if the update just hasn't appeared yet ( and I should be more patient ) or it hasn't appeared because it won't appear until i upgrade to v7. Hope that makes some semblance of sense. Thanks

BenjV · 2021-09-02T14:02:06Z

Version 3.00-19 is available for both DSM 6 as well as DSM 7 as of yesterday
What architecture is your Nas?

You can always download it and do a manual install.
Download can be found here.
https://synocommunity.com/package/transmission

spyrodragon1 · 2021-09-02T14:05:35Z

@BenjV - It's a DS220+ (INTEL Celeron J4025) currently running DSM 6.2.4-25556. Happy to download it manually but not sure what package I would take from that list.....thanks

BenjV · 2021-09-02T14:08:04Z

You need the geminilake version for a DS220+
zie:
https://github.com/SynoCommunity/spksrc/wiki/Architecture-per-Synology-model

spyrodragon1 · 2021-09-02T14:21:03Z

@BenjV - Sorry again for the stupid question but it says transmission 3.00-19 was the 1st November 2020 release on that page ?

Update openssl to 1.1.
Date
2020-11-01 17:01:28.615450

Apologies again if I'm missing something.....

BenjV · 2021-09-02T14:28:36Z

Most likely a mistake in a year field.
This version is currently the latest build.

vjayer · 2023-08-07T04:10:24Z

You need the geminilake version for a DS220+ zie: https://github.com/SynoCommunity/spksrc/wiki/Architecture-per-Synology-model
@spyrodragon1
sorry for the necroposting reply but just wanted to place this in case others have the same question.
Gemini Lake is the Intel codename for the family that includes the Celeron J4025
https://ark.intel.com/content/www/us/en/ark/products/197307/intel-celeron-processor-j4025-4m-cache-up-to-2-90-ghz.html
so your DS220+ should be supported

publicarray changed the title ~~Transmission DSM7 support~~ Transmission DSM7 support [WIP] Jul 8, 2021

publicarray changed the title ~~Transmission DSM7 support [WIP]~~ Transmission DSM7 support Jul 8, 2021

publicarray added the status/needs-review label Jul 8, 2021

publicarray mentioned this pull request Jul 9, 2021

Meta: DSM7 package status #4524

Open

hgy59 mentioned this pull request Jul 11, 2021

DS920 DSM7 Transmission wont be repaired #4732

Closed

publicarray mentioned this pull request Jul 20, 2021

Use installer resources for DSM6, update TCL package #4562

Closed

3 tasks

publicarray force-pushed the transmission7.0 branch 3 times, most recently from 7b42468 to b2e61e3 Compare August 16, 2021 03:55

publicarray mentioned this pull request Aug 16, 2021

Framework DSM7: shared folder worker fails #4766

Closed

publicarray requested a review from hgy59 August 17, 2021 11:04

publicarray mentioned this pull request Aug 19, 2021

TRANSMISSION for DSM 7.0 #4799

Closed

publicarray and others added 14 commits August 28, 2021 13:21

[Transmission] Acquire Shared folder resource/permissions

a51155e

set using SERVICE_WIZARD_SHARE only disadvantage is that this does not support sub-folders currently [Transmission] fix empty volume, consistency with naming

Transmission: Remove busybox from deps (#4373)

5096590

* Remove busybox dep * transmission: remove unnecessary GROUP setting from service-setup.sh * transmission: set GROUP for backwards compatibility * Undo SPK_REV/CHANGELOG * Adjust wizard text * Remove now superfluous busybox configs

Transmission: mentionnès -> mentionnés

4b4a035

Transmission fix upgrade from dsm6

f184908

fix shared folder resource worker on DSM6

9d92dcd

style fix

8c5efcf

Also update the download folder on upgrades

248c714

set default volume

89ecc38

useful when using `synopkg install`

fix shellcheck warning

3a9dc6d

improve messages

54383ea

transmission: attempt to create folders

504d53b

transmission: Let the package manage the "watch" and "incomplete"

ec52657

folders for DSM7

fix DSM Version specific Wizards

85c10f2

transmission: Let the package manage the "watch" and "incomplete"

222a49d

hgy59 reviewed Aug 28, 2021

View reviewed changes

publicarray added 3 commits August 29, 2021 10:01

Update python path

05a3a96

don't use legacy group for DSM7

cf67243

cleanup

e7de616

publicarray added status/ready-to-merge and removed status/needs-review labels Aug 31, 2021

publicarray merged commit f5fc4a3 into master Aug 31, 2021

publicarray added status/published Published and activated (may take up to 48h until visible in DSM package manager) and removed status/ready-to-merge labels Aug 31, 2021

publicarray deleted the transmission7.0 branch August 31, 2021 02:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Transmission DSM7 support #4719

Transmission DSM7 support #4719

publicarray commented Jul 8, 2021 •

edited

Loading

mreid-tt commented Aug 7, 2021

publicarray commented Aug 17, 2021 •

edited

Loading

Selenuix commented Aug 17, 2021

publicarray commented Aug 19, 2021

hgy59 Aug 28, 2021

publicarray Aug 28, 2021 •

edited

Loading

BenjV Aug 28, 2021 •

edited

Loading

publicarray Aug 29, 2021

hgy59 commented Aug 31, 2021

Zigwan06 commented Aug 31, 2021

BenjV commented Aug 31, 2021

spyrodragon1 commented Aug 31, 2021

publicarray commented Sep 1, 2021 •

edited

Loading

mreid-tt commented Sep 1, 2021

gemmmo commented Sep 1, 2021

isr25 commented Sep 1, 2021

gemmmo commented Sep 1, 2021

BenjV commented Sep 1, 2021

gemmmo commented Sep 1, 2021

BenjV commented Sep 1, 2021

gemmmo commented Sep 1, 2021

spyrodragon1 commented Sep 2, 2021

BenjV commented Sep 2, 2021

spyrodragon1 commented Sep 2, 2021 •

edited

Loading

BenjV commented Sep 2, 2021 •

edited

Loading

spyrodragon1 commented Sep 2, 2021

BenjV commented Sep 2, 2021

vjayer commented Aug 7, 2023 •

edited

Loading

Transmission DSM7 support #4719

Transmission DSM7 support #4719

Conversation

publicarray commented Jul 8, 2021 • edited Loading

Checklist

mreid-tt commented Aug 7, 2021

publicarray commented Aug 17, 2021 • edited Loading

Selenuix commented Aug 17, 2021

publicarray commented Aug 19, 2021

hgy59 Aug 28, 2021

Choose a reason for hiding this comment

publicarray Aug 28, 2021 • edited Loading

Choose a reason for hiding this comment

BenjV Aug 28, 2021 • edited Loading

Choose a reason for hiding this comment

publicarray Aug 29, 2021

Choose a reason for hiding this comment

hgy59 commented Aug 31, 2021

Zigwan06 commented Aug 31, 2021

BenjV commented Aug 31, 2021

spyrodragon1 commented Aug 31, 2021

publicarray commented Sep 1, 2021 • edited Loading

mreid-tt commented Sep 1, 2021

gemmmo commented Sep 1, 2021

isr25 commented Sep 1, 2021

gemmmo commented Sep 1, 2021

BenjV commented Sep 1, 2021

gemmmo commented Sep 1, 2021

BenjV commented Sep 1, 2021

gemmmo commented Sep 1, 2021

spyrodragon1 commented Sep 2, 2021

BenjV commented Sep 2, 2021

spyrodragon1 commented Sep 2, 2021 • edited Loading

BenjV commented Sep 2, 2021 • edited Loading

spyrodragon1 commented Sep 2, 2021

BenjV commented Sep 2, 2021

vjayer commented Aug 7, 2023 • edited Loading

publicarray commented Jul 8, 2021 •

edited

Loading

publicarray commented Aug 17, 2021 •

edited

Loading

publicarray Aug 28, 2021 •

edited

Loading

BenjV Aug 28, 2021 •

edited

Loading

publicarray commented Sep 1, 2021 •

edited

Loading

spyrodragon1 commented Sep 2, 2021 •

edited

Loading

BenjV commented Sep 2, 2021 •

edited

Loading

vjayer commented Aug 7, 2023 •

edited

Loading