Sabnzbd DSM7 #4748

publicarray · 2021-07-21T03:16:27Z

Motivation:
Linked issues: Followup from #4658

Checklist

Build rule all-supported completed successfully
Package upgrade completed successfully
New installation of package completed successfully

publicarray · 2021-07-21T10:28:47Z

squidguard failed to build

Safihre · 2021-07-21T10:55:36Z

spk/sabnzbd/src/service-setup.sh

@@ -50,5 +51,7 @@ service_postupgrade ()
        if [ -n "${WATCHED_FOLDER}" ] && [ -d "${WATCHED_FOLDER}" ]; then
            set_syno_permissions "${WATCHED_FOLDER}" "${GROUP}"
        fi
+        # DSM6 -> DSM7 migration
+        sed -i -e "s|script_dir\s*=.*|script_dir = ${SYNOPKG_PKGVAR}/scripts|g" ${CFG_FILE}


Since this is an upgrade, shoudln't this only trigger if script_dir=/usr/local/sabnzbd/var/scripts?

Or script_dir = /usr/local/sabnzbd/var/scripts (so with spaces).

Actually a good question. At first I was with you but consider that a user updates or installs (this version) their package on DSM6 the path is changed to /var/packages/sabnzbd/target/var then later they update to DSM7 and the package gets reinstalled. the new path is /var/packages/sabnzbd/var

So it covers both upgrade paths.

Or in other words I know that ${SYNOPKG_PKGVAR}/scripts is always the correct path. Setting it every time ensures it is the correct one, and I don't potentially leave out a case where it is not modified.

But, what if the user has set a custom path to somewhere on it's NAS?

@Safihre is it documented that this path is user changeable, if not, how can we be sure that there is a single user out there that has changed it?

Users can easily change it from the SABnzbd interface. The example is on Windows, but on DSM it would show the /var/..... path from the ini.

Safihre · 2021-07-21T10:57:29Z

spk/sabnzbd/src/wizard/upgrade_uifile

@@ -1,9 +1,64 @@
-[{
+[


So wizards are supported? I am so confused 😨

As far as I understand it. For now they work as before but officially they are no longer supported by Synology. I hope Synology can come up with an alternative. Their own packages and 3rd party still use them. So I think eventually we have to phase them out by setting default values or something.

But honestly I just don't know 🤷‍♂️

Safihre · 2021-07-22T07:36:17Z

squidguard failed to build

Just as in #4658 it's just a missing dependency, unrelated to unrar:

  ===>  Downloading files for squidclamav
  ===>    wget https://downloads.sourceforge.net/project/squidclamav/squidclamav/6.10/squidclamav-6.10.tar.gz
  https://downloads.sourceforge.net/project/squidclamav/squidclamav/6.10/squidclamav-6.10.tar.gz:
  2021-07-21 03:36:59 ERROR 404: Not Found.

Safihre · 2021-07-27T07:36:41Z

@hgy59 Can you review this for @publicarray ? :)

hgy59

Installation succeeded on DSM-6.2.4 and DSM-7.0

My findings are, that the sc-download group is not added to the download folder (verified with synoacltool --list {share-name}).
And changing the download folder with the upgrade wizard, does not change the sabnzbd configuration. The config must be updated manually - this might be worth a note in the upgrade wizard.
IMO the upgrade wizard can be removed, as it is always possible to configure another shared folder (and adjusting the permissions at package upgrade does not work anymore).

publicarray · 2021-07-31T22:42:54Z

My findings are, that the sc-download group is not added to the download folder (verified with synoacltool --list {share-name}).

Thanks Hm, it looks like manually adding the sc-download group is overridden by the wizard shared worker (during a stop/start of the package).

And changing the download folder with the upgrade wizard, does not change the sabnzbd configuration. The config must be updated manually - this might be worth a note in the upgrade wizard.

👍 download_dir is Fixed

IMO the upgrade wizard can be removed, as it is always possible to configure another shared folder (and adjusting the permissions at package upgrade does not work anymore).

True I guess, I just wanted to support the migration for DSM6 to DSM7 otherwise the package won't function since it's no longer part of the sc-download group after upgrade. The upgrade wizard was just there to add the sc-sabnzbd user to the shared folder. Ideally you would choose the same folder used before the upgrade.

publicarray · 2021-07-31T23:23:59Z

@hgy59 do we actually need the wizard_volume and wizard_download_dir to be user configurable with SERVICE_WIZARD_SHARE?

publicarray · 2021-07-31T23:37:50Z

For the upgrade wizard it would be nice to have it for the dsm7 package only.

publicarray · 2021-08-03T14:09:31Z

@hgy59 how is it looking now?

mreid-tt · 2021-08-07T10:41:58Z

i see some challenging work is in progress to bring this package to DSM7. looking forward to this package's release

Safihre · 2021-08-12T09:40:07Z

Maybe we should give it a try?

publicarray · 2021-08-12T22:16:51Z

@RoadRunnr I hope you don't mind me asking, but which branch are you using to compile the package? The behaviour you are seeing would match if you compiled from the master branch and not from the fixed version in this PR: https://github.com/publicarray/spksrc/tree/sabnzbd330 but of course I could be wrong too.

RoadRunnr · 2021-08-13T09:04:01Z

OMG, I could have sworn I was on the correct branch, but you are correct, the spk was not build from your branch/this PR.

It works now. So, forget all my comments above.

publicarray · 2021-08-13T09:51:32Z

@RoadRunnr I'm glad we got it sorted in the end. 😅

@Safihre what are you asking to try?

Safihre · 2021-08-13T10:09:48Z

@publicarray Not sure anymore, kind of lost what we still need to get things working fully 😅

publicarray · 2021-08-13T10:20:38Z

It looks good to merge INHO. I just think @hgy59 was wondering if we should remove the upgrade wizard. The reason I did include it, was to support the upgrade from dsm6 to dsm7, so the shared folder gets the new permissions and the package can start without issues. But I guess it's easy to do so manually too.

My suggestion is to only use the upgrade wizard for the DSM7 version and only on packages were the shared folder was originally created through the install wizard.

megahdj · 2021-08-13T12:35:32Z

Seems a lot of work to be done amping this app to DSM 7, want to say that i look forward to use this app again.
Keep up the good work. Thank you all.

yaremam · 2021-08-16T21:26:33Z

Thanks for the hard work guys! I hope it will be merged soon!

publicarray · 2021-09-02T06:49:51Z

Dear @CatStarwind the package is not published yet. Please read our README

Pontation · 2021-09-06T11:13:46Z

Hello, thank you for your effort in fixing this! I don't know if more time needs to pass for the package gets updated in the Package center, but I just tested again and I'm still getting the "Invalid fileformat. Contact the package developer." (might be a slitly different translation) error message. Do I just wait or is something wrong?

publicarray · 2021-09-06T11:59:30Z

It can take 48 hours for the CDN to catch up. (This is on purpose, so the CDN can soak up over 90% of the traffic)

oliverspike · 2021-09-06T12:12:25Z

it is working for now thank you so much guys for the update ! you guys are amazing !

Junkt0wn · 2021-09-06T15:05:01Z

Hi,

I'm doing a fresh install of this package and I get the same as Pontation "Invalid File Format. Please contact the package developer"

Can anyone confirm that they're able to get a copy with a complete reinstall (not a repair)?

I'm using a DS1817+

Understand that it hasn't quite been 48 hours as of yet but unsure if this is a regional and won't be available to me as of yet given that I'm in Melbourne Australia.

Edit#1 (07/09/21)
This has come through now. Only thing now is that it doesn't seem to have permissions to use the already established complete/incomplete folders that DSM6+ was using.

I've also delete those folders and tried to get it to re-create them but no luck

Edit#2 (07/09/21)
So the issue becomes that you cannot use a pre-existing shared folder for your downloads destination.

I needed to create a new one. I assume that this is due to that it doesn't have ownership to begin with so therefore it can't adjust any of the proper permissions.

Perhaps this isn't a big deal and I might be unique in this situation having done a fresh install on DSM7

oliverspike · 2021-09-06T15:07:38Z

Hello,

I did a fresh install and it works perfectly, removed all my old setup, backuped all I wanted to keep. reimport the configuration took me just 5 minutes everything works.

mreid-tt · 2021-09-06T17:39:38Z

Completed a repair/upgrade on DSM7 without any issues. My entire download history came across smoothly and all of my keys for API access are working without issue (as they did before). All in all a flawless upgrade thus far. Great job team!

chriscamicas · 2021-09-06T18:47:56Z

Thanks everyone for your wonderful work here.
But it's not working on my side
I guess my arch (INTEL Atom C2538) is not supported yet, I see the Build (x64-7.0) has failed
Does it need to be fixed for the package to be published ?

mreid-tt · 2021-09-07T03:08:07Z

I don't know if this is an issue for here or not so I posted this in the SABnzbd forum support... https://forums.sabnzbd.org/viewtopic.php?t=25515

Essentially I did a test download with Lidarr and got a permissions issue. I followed the setup in the wiki but this didn't seem to resolve the issue; let me know if I should open a new issue here or not.

UPDATE: I found a workaround for the download processing in Lidar not completing. I just updated the Permissions for completed downloads (under Config > Folders and check the Advanced Settings box) to '777'. Hope this helps others.

turtleonabike · 2021-09-07T08:28:03Z

I have tested on INTEL Celeron J4125 and works as expected.

Thank you to everyone who helped.

chriscamicas · 2021-09-07T08:29:16Z

Thanks everyone for your wonderful work here.
But it's not working on my side
I guess my arch (INTEL Atom C2538) is not supported yet, I see the Build (x64-7.0) has failed
Does it need to be fixed for the package to be published ?

Nevermind, it works now !
Thank you !

SPT212 · 2021-09-07T23:37:56Z

Hi, I installed "sabnzbd.v49.f41890[rtd1296-armada37xx-aarch64]" successfully, but whenever I try to run it on the native HTTP port (8080), I get the message that "the site cannot be reached" and "refused to connect," but the package installs without any issues. I have played with permissions and port forwarding extensively to no avail and everything was working perfectly before DSM 7 update. Any help would be greatly appreciated.

publicarray · 2021-09-07T23:46:18Z

Please create a new issue with the necessary log files. Without logs I'm also clueless. You can verify if the program is running with ps

SPT212 · 2021-09-07T23:52:23Z

Apologies for the newb question, but how and what log files should I compile? Also, what do you mean when you say I can verify with "ps"? Thank you

publicarray · 2021-09-08T02:25:36Z

Not at all @SPT212 no problem, if you enable ssh access on your NAS you can use ssh to get the log files:
cat /var/packages/sabnzbd/target/var/sabnzbd.log to print out the sabnzbd log file and cat /var/log/packages/sabnzbd.log for the installation log.

ps axu lists all current possesses running on the system, but the build in task manager can do the same job. Can you see if the sabnzbd process is running?

SPT212 · 2021-09-08T04:04:33Z

I started an issue with the requested: #4846

Thanks so much for the help!

skenttaylor · 2021-09-08T08:39:19Z

Many thanks for your work on this. What a great community.

The main Synocommunity page says "You can also support us by donating to our contributors." I've been looking for a way to do this. Is there a tip jar/donate link I can use to show my appreciation?

Edit: Ah, just found this link: https://sabnzbd.org/donate/

Second edit: No, that's for sabnzdb itself (which I'm also happy to donate to). I'd like to toss a coin to the people who got it working for DSM7.

MisterAFCA · 2021-09-08T13:28:42Z

Did a clean install because I had some ip issues. Works like charm! Thank you so much for al your effort and hard work guys!!! You are the best!

italeet · 2021-09-14T22:33:11Z

Just completed update to DSM7 and trying to do fresh install of Sabnzbd, after installation is completed it automatically ask me to repair the package, fails to repair and then i get this message.

Safihre · 2021-09-15T05:18:07Z

This is not the place for such reports, please open a issue and report the right logs.

publicarray requested a review from Safihre July 21, 2021 03:17

publicarray added the status/needs-review label Jul 21, 2021

Safihre reviewed Jul 21, 2021

View reviewed changes

publicarray requested a review from hgy59 July 22, 2021 02:14

hgy59 reviewed Jul 27, 2021

View reviewed changes

hgy59 mentioned this pull request Jul 28, 2021

Update minio to 2021-09-09T21-37-07Z #4683

Merged

6 tasks

This comment has been minimized.

Sign in to view

publicarray mentioned this pull request Aug 9, 2021

Framework DSM7: shared folder worker fails #4766

Closed

This comment has been minimized.

Sign in to view

publicarray mentioned this pull request Aug 16, 2021

Impossible to download sabnzbd on Synology ds416j #4791

Closed

SynoCommunity locked and limited conversation to collaborators Sep 2, 2021

albino1 mentioned this pull request Sep 2, 2021

Upgrade DSM 6.2 to DSM 7 Sabnzbd reports Invalid file format, contact package developer. sabnzbd/sabnzbd#1945

Closed

cleanup

36c523d

publicarray removed the status/needs-review label Sep 5, 2021

publicarray merged commit bf70021 into SynoCommunity:master Sep 5, 2021

publicarray deleted the sabnzbd330 branch September 5, 2021 13:16

SynoCommunity unlocked this conversation Sep 5, 2021

publicarray added the status/published Published and activated (may take up to 48h until visible in DSM package manager) label Sep 5, 2021

SynoCommunity locked as resolved and limited conversation to collaborators Sep 15, 2021

Sabnzbd DSM7 #4748

Sabnzbd DSM7 #4748

Conversation

publicarray commented Jul 21, 2021 • edited Loading

Checklist

publicarray commented Jul 21, 2021

Choose a reason for hiding this comment

Choose a reason for hiding this comment

publicarray Jul 21, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

publicarray Jul 21, 2021 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Safihre commented Jul 22, 2021

Safihre commented Jul 27, 2021

hgy59 left a comment

Choose a reason for hiding this comment

publicarray commented Jul 31, 2021 • edited Loading

publicarray commented Jul 31, 2021

publicarray commented Jul 31, 2021

publicarray commented Aug 3, 2021

This comment has been minimized.

mreid-tt commented Aug 7, 2021

This comment has been minimized.

Safihre commented Aug 12, 2021

This comment has been minimized.

publicarray commented Aug 12, 2021 • edited Loading

RoadRunnr commented Aug 13, 2021

publicarray commented Aug 13, 2021

Safihre commented Aug 13, 2021

publicarray commented Aug 13, 2021

megahdj commented Aug 13, 2021

yaremam commented Aug 16, 2021

publicarray commented Sep 2, 2021

Pontation commented Sep 6, 2021

publicarray commented Sep 6, 2021 • edited Loading

oliverspike commented Sep 6, 2021

Junkt0wn commented Sep 6, 2021 • edited Loading

oliverspike commented Sep 6, 2021

mreid-tt commented Sep 6, 2021

chriscamicas commented Sep 6, 2021

mreid-tt commented Sep 7, 2021 • edited Loading

turtleonabike commented Sep 7, 2021

chriscamicas commented Sep 7, 2021

SPT212 commented Sep 7, 2021

publicarray commented Sep 7, 2021 • edited Loading

SPT212 commented Sep 7, 2021

publicarray commented Sep 8, 2021 • edited Loading

SPT212 commented Sep 8, 2021

skenttaylor commented Sep 8, 2021 • edited Loading

MisterAFCA commented Sep 8, 2021

italeet commented Sep 14, 2021 • edited Loading

Safihre commented Sep 15, 2021

publicarray commented Jul 21, 2021 •

edited

Loading

publicarray Jul 21, 2021 •

edited

Loading

publicarray Jul 21, 2021 •

edited

Loading

publicarray commented Jul 31, 2021 •

edited

Loading

publicarray commented Aug 12, 2021 •

edited

Loading

publicarray commented Sep 6, 2021 •

edited

Loading

Junkt0wn commented Sep 6, 2021 •

edited

Loading

mreid-tt commented Sep 7, 2021 •

edited

Loading

publicarray commented Sep 7, 2021 •

edited

Loading

publicarray commented Sep 8, 2021 •

edited

Loading

skenttaylor commented Sep 8, 2021 •

edited

Loading

italeet commented Sep 14, 2021 •

edited

Loading