Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy requirements #935

Closed
evgueni-ovtchinnikov opened this issue Jun 1, 2021 · 1 comment · Fixed by #937
Closed

numpy requirements #935

evgueni-ovtchinnikov opened this issue Jun 1, 2021 · 1 comment · Fixed by #937
Assignees
@evgueni-ovtchinnikov
Milestone
v3.1

Comments

@evgueni-ovtchinnikov
Copy link
Contributor

After merging PR #881, numpy must be at least 1.18.0, otherwise Gadgetron.calc_cartesian_dcw fails.

@KrisThielemans @ashgillman I understand requirements.txt is for pip install - should I add a new line numpy >= 1.18.0 there?
@evgueni-ovtchinnikov evgueni-ovtchinnikov added this to the v3.1 milestone Jun 1, 2021
@evgueni-ovtchinnikov evgueni-ovtchinnikov self-assigned this Jun 1, 2021
ashgillman added a commit that referenced this issue Jun 2, 2021
@ashgillman
Numpy >= 1.18
7cb0ef6 
Fixes #935
@ashgillman ashgillman mentioned this issue Jun 2, 2021
Merged
@ashgillman
Copy link
Member

Yes, that sounds correct. Note this won't be reflected in the VM yet: SyneRBI/SyneRBI_VM#189

I've just made a quick PR in the web interface as I'm out-of-office, hopefully CI is successful.

KrisThielemans added a commit that referenced this issue Jun 2, 2021
@KrisThielemans
Merge pull request #937 from SyneRBI/ashgillman-patch-1
7846174 
Numpy >= 1.18

Fixes #935
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evgueni-ovtchinnikov evgueni-ovtchinnikov

Labels
None yet
Projects
None yet
Milestone
v3.1
Development

Successfully merging a pull request may close this issue.

Numpy >= 1.18 SyneRBI/SIRF
2 participants
@ashgillman @evgueni-ovtchinnikov