Skip to content
This repository has been archived by the owner on Aug 20, 2022. It is now read-only.

Only SIRF-Exercises requirements.txt is installed #189

Open
ashgillman opened this issue May 27, 2021 · 3 comments
Open

Only SIRF-Exercises requirements.txt is installed #189

ashgillman opened this issue May 27, 2021 · 3 comments
Assignees

Comments

@ashgillman
Copy link
Member

On VM I had issues running due to missing dependency deprecation. I don't know if we want to add this to SIRF-Exercises?

Either way, it probably makes sense to also install from SIRF/requrirements.txt

@KrisThielemans
Copy link
Member

I don't know if we want to add this to SIRF-Exercises?

not sure what you mean

it probably makes sense to also install from SIRF/requrirements.txt

are you saying as part of the update_VM.sh run SIRF/requrirements.txt? That sounds like a good idea.

@ashgillman
Copy link
Member Author

I don't know if we want to add this to SIRF-Exercises?

not sure what you mean

My thought was that the deprecation is evidently required by the notebooks - since I got an error. So we could explicitly add it to SIRF-Exercises/requirements.txt here. The more I think about it though, we only need it indirectly so I don't think it should be there.

it probably makes sense to also install from SIRF/requrirements.txt

are you saying as part of the update_VM.sh run SIRF/requrirements.txt? That sounds like a good idea.

👍

@KrisThielemans
Copy link
Member

oh, you mean the deprecation package. yeah, that should be handled via SIRF.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants