Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nema data preparation #3

Merged
merged 30 commits into from
Jun 18, 2024
Merged

Nema data preparation #3

merged 30 commits into from
Jun 18, 2024

Conversation

KrisThielemans
Copy link
Member

don't merge!

Likely this code will go into SIRF

@casperdcl casperdcl mentioned this pull request Apr 16, 2024
11 tasks
@KrisThielemans
Copy link
Member Author

thanks. this will have to be converted to a function, such that we can run it on other data that we get (i.e. most of it should not be NEMA specific). It would make most sense if there is some diagnostics written to a logfile (although that could be handled by just redirecting output). I think we need output files in 2 directories:

  • one with only the final output (prompts, multfactors, additive term)
  • another one with other intermediate files (ac/acfs, norm, randoms, scatter, whatever) and log of conversion

we also need a "quick reconstruction OSEM" at the end, with output images save in the "final" dir as Interfile, and 3 pngs (transverse, sagittal, coronal, all 3 middle slices) in the "other" directory for a quick visual check that all went fine.

Unfortunately, OSEM settings will be scanner dependent (also for the scatter by the way), but ok to hardwire 21 subsets, 21 updates, for the mMR for now.

Copy link
Member Author

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • remove old/* files
  • create separate script download_Siemens_mMR_NEMA_IQ to download/mMR_NEMA_IQ
    • download from zenodo
    • copy mMR_template_span11.hs from sirf_data_path = os.path.join(examples_data_path('PET'), 'mMR')

lib/sirf_exercises/__init__.py Outdated Show resolved Hide resolved
lib/sirf_exercises/__init__.py Outdated Show resolved Hide resolved
lib/sirf_exercises/__init__.py Outdated Show resolved Hide resolved
lib/sirf_exercises/data_path.py Outdated Show resolved Hide resolved
lib/sirf_exercises/__init__.py Outdated Show resolved Hide resolved
src/SIRF_data_preparation/prepare_data.py Outdated Show resolved Hide resolved
lib/sirf_exercises/__init__.py Outdated Show resolved Hide resolved
Copy link
Member Author

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Final clean-up in comments. Also, please do move src/SIRF_data_preparation/prepare_data.py to src/SIRF_data_preparation/prepare_mMR_NEMA_IQ_data.py

lib/data_utilities/__init__.py Outdated Show resolved Hide resolved
src/SIRF_data_preparation/prepare_data.py Outdated Show resolved Hide resolved
src/SIRF_data_preparation/prepare_data.py Outdated Show resolved Hide resolved
src/SIRF_data_preparation/prepare_data.py Outdated Show resolved Hide resolved
lib/data_utilities/__init__.py Outdated Show resolved Hide resolved
lib/data_utilities/__init__.py Outdated Show resolved Hide resolved
lib/data_utilities/__init__.py Outdated Show resolved Hide resolved
lib/data_utilities/__init__.py Outdated Show resolved Hide resolved
src/SIRF_data_preparation/prepare_data.py Outdated Show resolved Hide resolved
lib/data_utilities/__init__.py Outdated Show resolved Hide resolved
@KrisThielemans
Copy link
Member Author

create separate script download_Siemens_mMR_NEMA_IQ to download/mMR_NEMA_IQ

  • download from zenodo
  • copy mMR_template_span11.hs from sirf_data_path = os.path.join(examples_data_path('PET'), 'mMR')

this wasn't done yet.

Copy link
Member Author

@KrisThielemans KrisThielemans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few more gremlins.

Also still need to rename the prepare_data.py

lib/data_utilities/__init__.py Outdated Show resolved Hide resolved
src/SIRF_data_preparation/prepare_data.py Outdated Show resolved Hide resolved
lib/data_utilities/__init__.py Outdated Show resolved Hide resolved
lib/data_utilities/__init__.py Show resolved Hide resolved
lib/data_utilities/__init__.py Show resolved Hide resolved
lib/data_utilities/__init__.py Outdated Show resolved Hide resolved
lib/data_utilities/__init__.py Outdated Show resolved Hide resolved
@KrisThielemans KrisThielemans merged commit ec7a95e into main Jun 18, 2024
@KrisThielemans KrisThielemans deleted the nema-data branch June 18, 2024 16:31
@casperdcl casperdcl added the data label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants