Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

prepare_data.py start and stop #10

Closed
paskino opened this issue Jun 7, 2024 · 2 comments
Closed

prepare_data.py start and stop #10

paskino opened this issue Jun 7, 2024 · 2 comments
Assignees
@evgueni-ovtchinnikov
Labels
data

Comments

@paskino
Copy link
Contributor

paskino commented Jun 7, 2024

The prepare_data.py script has harcoded 2 floats start and stop as 0 and 10 respectively.

https://github.com/SyneRBI/Challenge24/blob/7d7942e3fc30f3751d03f805f3d30463d68593b4/lib/sirf_exercises/__init__.py#L115

My understanding is that this is these are governing the time range of the data converted.

  1. is this true?
  2. what is the unit measure?
  3. how can one request to process all of the data?
@paskino paskino mentioned this issue Jun 7, 2024
Closed
@KrisThielemans
Copy link
Member

Second. Help message hopefully says so, but usersguide as well.

For this scan, using all data is too much...

@KrisThielemans
Copy link
Member

This was fixed in #3

@casperdcl casperdcl added the data label Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evgueni-ovtchinnikov evgueni-ovtchinnikov

Labels
data
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@KrisThielemans @casperdcl @paskino @evgueni-ovtchinnikov