Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for Symfony 7 #863

Merged
merged 28 commits into from
Sep 5, 2024
Merged

Adding support for Symfony 7 #863

merged 28 commits into from
Sep 5, 2024

Conversation

loic425
Copy link
Member

@loic425 loic425 commented Apr 9, 2024

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Related tickets
License MIT

This PR replaces #840

@loic425 loic425 requested a review from a team as a code owner April 9, 2024 07:01
@loic425 loic425 changed the title Symfony 7 Adding support for Symfony 7 Apr 9, 2024
@loic425 loic425 changed the title Adding support for Symfony 7 [WIP] Adding support for Symfony 7 Apr 22, 2024
@loic425 loic425 marked this pull request as draft April 22, 2024 14:01
@loic425 loic425 force-pushed the symfony-7 branch 2 times, most recently from 934b048 to 33a7971 Compare April 26, 2024 12:32
@loic425 loic425 changed the base branch from 1.11 to 1.12 May 15, 2024 14:38
@loic425 loic425 mentioned this pull request Jun 5, 2024
74 tasks
@loic425 loic425 marked this pull request as ready for review August 29, 2024 14:10
@loic425 loic425 changed the title [WIP] Adding support for Symfony 7 Adding support for Symfony 7 Aug 29, 2024
@GSadee GSadee added the Maintenance Configurations, READMEs, releases, etc. label Sep 4, 2024
.github/workflows/build.yml Outdated Show resolved Hide resolved
-
name: Remove hateoas on Symfony 7
if: matrix.symfony == '^7.0'
run: composer remove --dev willdurand/hateoas-bundle --no-update --no-scripts
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this package still a problem? The newest version supports SF7 if I see correctly.
Ref.: https://packagist.org/packages/willdurand/hateoas-bundle#2.6.0

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, there is an issue => willdurand/BazingaHateoasBundle#108

composer.json Show resolved Hide resolved
@loic425
Copy link
Member Author

loic425 commented Sep 4, 2024

I have an issue that I do not reproduce locally with SF7.1.

@loic425 loic425 mentioned this pull request Sep 4, 2024
"symfony/stopwatch": "^5.4 || ^6.4",
"symfony/uid": "^5.4 || ^6.4",
"symfony/workflow": "^5.4 || ^6.4",
"sylius/grid-bundle": "^1.7 || dev-symfony-7",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"sylius/grid-bundle": "^1.7 || dev-symfony-7",
"sylius/grid-bundle": "^1.7 || dev-1.13",

@GSadee GSadee merged commit 2a908ba into 1.12 Sep 5, 2024
39 checks passed
@GSadee
Copy link
Member

GSadee commented Sep 5, 2024

Thank you, Loïc! 🎉

@GSadee GSadee deleted the symfony-7 branch September 5, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants