Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 7 support #15481

Closed
74 tasks done
loic425 opened this issue Oct 30, 2023 · 11 comments
Closed
74 tasks done

Symfony 7 support #15481

loic425 opened this issue Oct 30, 2023 · 11 comments
Milestone

Comments

@loic425
Copy link
Member

loic425 commented Oct 30, 2023

Final steps

Internal Components

  • Addressing
  • Attribute
  • Channel
  • Core
  • Currency
  • Customer
  • Inventory
  • Locale
  • Order
  • Payment
  • Product
  • Promotion
  • Review
  • Shipping
  • Taxation
  • Taxonomy
  • User

Internal Bundles

Internal PRs

Sylius technical packages

External Packages

@mbabker
Copy link
Contributor

mbabker commented Oct 30, 2023

babdev/pagerfanta-bundle

I don't intend on making the 3.x branch compatible with Symfony 7; generally, I keep my Symfony bundles compatible with two LTS' and the next major (3.x supports Symfony 4.4, 5.4, and 6.x; 4.x will support Symfony 5.4, 6.4, and 7.x). So, Sylius will need to upgrade to PagerfantaBundle 4.0 for Symfony 7 support. In good news, the 3.x to 4.x upgrade is much lighter this time around compared to the 3.x releases which had all sorts of internal refactoring and cleanup.

@loic425 loic425 pinned this issue Nov 7, 2023
@loic425
Copy link
Member Author

loic425 commented Nov 8, 2023

thx @mbabker for all your work on external packages.

@jakubtobiasz
Copy link
Contributor

Hi,
I just want to clarify Symfony 7 support is about Sylius 2.x. Sylius 1.x won't support it.

@jakubtobiasz jakubtobiasz added this to the 2.0 milestone Dec 11, 2023
@alexander-schranz
Copy link
Contributor

alexander-schranz commented Apr 5, 2024

FOSRestBundle is released with Symfony 7 support aslong as you don't use the SensioExtraBundle features. Thx to @mbabker

@loic425
Copy link
Member Author

loic425 commented Apr 6, 2024

Ok that means that we are now ready to work on technical packages 🎉

@loic425
Copy link
Member Author

loic425 commented Apr 6, 2024

Payum is also ready on master branch, @lchrusciel @diimpp are you ready to rumble?

@nbro
Copy link

nbro commented May 22, 2024

Does this mean that you're going to convert all models/entities to use PHP attributes? That would be great because right now Sylius entities (which for some reason you call models) are very confusing given that the Maker Bundle creates entities with attributes by default (which I like - I really don't like the comments or XML approaches), while it seems that Sylius uses another approach (not sure if it uses comments or XML configurations or both - I've seen everything and nothing), which is confusing to me.

Also, could someone tell me which Maker Bundle version I should use, so that I create entities which are compatible with Sylius? Version ^1.59 is not compatible because it creates entities with attributes and if I try to migrate, nothing is migrated, i.e. entities are not recognized as such. I followed the official documentation to create a new entity.

@jakubtobiasz
Copy link
Contributor

Hi @nbro,

  1. Sylius internally will stay with XML files, as it is a recommended way for bundles.
  2. AFAIR since 1.13 Sylius-Standard has attributes enabled by default. So, compare your config/packages/doctrine.yaml with the latest one (https://github.com/Sylius/Sylius-Standard/blob/1.13/config/packages/doctrine.yaml).
  3. The only drawback is for some plugins not defining attributes you might need to write attribute definitions on your own.

@nbro
Copy link

nbro commented May 22, 2024

@jakubtobiasz Thanks for the answer.

My config/packages/doctrine.yaml looked exactly like that one except that I had type: annotation instead of type: attribute. After this change, the migrations worked, so now I have my table!

However, I had created my local Sylius application with composer create-project sylius/sylius-standard MySyliusProject and I hadn't modified the doctrine.yaml (I think). And I did this just a few days ago, but maybe I'm mistaking or something. The installed Sylius version is ~1.13.0. I suppose this change is very recent and has not yet been released.

@jakubtobiasz
Copy link
Contributor

@nbro Updated Sylius Standard wasn't available at day 0 of Sylius 1.13 release. So, despite you've got Sylius 1.13 installed (as a constraint was probably met), the configuration was from 1.12 times :). You can always try to run this command once again and check whether it works :).

@alexander-schranz
Copy link
Contributor

ThemeBundle is done :)

loic425 added a commit that referenced this issue Aug 26, 2024
| Q               | A
|-----------------|-----
| Branch?         | symfony-7
| Bug fix?        | no
| New feature?    | no
| BC breaks?      | no
| Deprecations? | no<!-- don't forget to update the UPGRADE-*.md file
-->
| Related tickets | mentioned in
#15481
| License         | MIT

<!--
 - Bug fixes must be submitted against the 1.13 branch
 - Features and deprecations must be submitted against the 1.14 branch
- Features, removing deprecations and BC breaks must be submitted
against the 2.0 branch
 - Make sure that the correct base branch is set

To be sure you are not breaking any Backward Compatibilities, check the
documentation:

https://docs.sylius.com/en/latest/book/organization/backward-compatibility-promise.html
-->
@GSadee GSadee closed this as completed Oct 8, 2024
@CoderMaggie CoderMaggie unpinned this issue Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants