Adding support for Symfony 7 #863
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -44,6 +44,7 @@ parameters: | |
| - '/Call to method isChangeTrackingDeferredExplicit\(\) on an unknown class Doctrine\\ODM\\MongoDB\\Mapping\\ClassMetadata./' | ||
| - '/Call to an undefined method ReflectionClass::getAttributes\(\)./' | ||
| - '/Call to an undefined method object::getRealClassName\(\)./' | ||
| - '/Class Bazinga\\Bundle\\HateoasBundle\\BazingaHateoasBundle not found\./' | ||
| - '/Class Doctrine\\Bundle\\MongoDBBundle/' | ||
| - '/Class Doctrine\\Bundle\\PHPCRBundle/' | ||
| - '/Class Doctrine\\Common\\Persistence\\ObjectManager not found\./' | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -67,6 +67,12 @@ | |
| <file name="src/Bundle/Controller/Parameters.php" /> | ||
| </errorLevel> | ||
| </DuplicateClass> | ||
|
|
||
| <InternalClass> | ||
| <errorLevel type="suppress"> | ||
| <file name="src/Bundle/DependencyInjection/PagerfantaExtension.php" /> | ||
| </errorLevel> | ||
| </InternalClass> | ||
|
|
||
| <InternalMethod> | ||
| <errorLevel type="suppress"> | ||
|
|
@@ -168,6 +174,12 @@ | |
| </errorLevel> | ||
| </PossiblyNullArgument> | ||
|
|
||
| <PossiblyNullPropertyAssignmentValue> | ||
| <errorLevel type="suppress"> | ||
| <file name="src/Bundle/Controller/ContainerAwareTrait.php" /> | ||
| </errorLevel> | ||
| </PossiblyNullPropertyAssignmentValue> | ||
|
|
||
| <PossiblyNullReference> | ||
| <errorLevel type="suppress"> | ||
| <file name="src/Bundle/DependencyInjection/Configuration.php" /> | ||
|
|
@@ -198,6 +210,7 @@ | |
|
|
||
| <PropertyNotSetInConstructor> | ||
| <errorLevel type="suppress"> | ||
| <file name="src/Bundle/Routing/ResourceLoader.php" /> | ||
| <file name="src/Bundle/Validator/Constraints/UniqueWithinCollectionConstraint.php" /> | ||
| <file name="src/Bundle/Validator/Constraints/Enabled.php" /> | ||
| <file name="src/Bundle/Validator/Constraints/Disabled.php" /> | ||
|
|
@@ -250,10 +263,13 @@ | |
|
|
||
| <UndefinedClass> | ||
| <errorLevel type="suppress"> | ||
| <referencedClass name="Bazinga\Bundle\HateoasBundle\BazingaHateoasBundle" /> | ||
| <referencedClass name="Doctrine\Bundle\MongoDBBundle\DependencyInjection\Compiler\DoctrineMongoDBMappingsPass" /> | ||
| <referencedClass name="Doctrine\Bundle\PHPCRBundle\DependencyInjection\Compiler\DoctrinePhpcrMappingsPass" /> | ||
| <referencedClass name="Doctrine\Common\Persistence\ObjectManager" /> | ||
| <referencedClass name="Doctrine\ODM\MongoDB\Mapping\ClassMetadata" /> | ||
| <referencedClass name="Hateoas\Configuration\Route" /> | ||
| <referencedClass name="Hateoas\Representation\Factory\PagerfantaFactory" /> | ||
| <referencedClass name="Symfony\Component\ExpressionLanguage\ParserCache\ParserCacheAdapter" /> | ||
| <referencedClass name="Symfony\Component\ExpressionLanguage\ParserCache\ParserCacheInterface" /> | ||
| </errorLevel> | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| <?php | ||
|
|
||
| /* | ||
| * This file is part of the Sylius package. | ||
| * | ||
| * (c) Sylius Sp. z o.o. | ||
| * | ||
| * For the full copyright and license information, please view the LICENSE | ||
| * file that was distributed with this source code. | ||
| */ | ||
|
|
||
| declare(strict_types=1); | ||
|
|
||
| namespace Sylius\Bundle\ResourceBundle\Controller; | ||
|
|
||
| use Symfony\Component\DependencyInjection\ContainerInterface; | ||
|
|
||
| /** | ||
| * Copied from Symfony to keep using ResourceController as this trait has been removed in Symfony 7. | ||
| * Do not use this trait on your projects, use dependency injection instead. | ||
| * | ||
| * @see https://github.com/symfony/symfony/blob/6.4/src/Symfony/Component/DependencyInjection/ContainerAwareTrait.php | ||
| * | ||
| * @internal | ||
| */ | ||
| trait ContainerAwareTrait | ||
| { | ||
| protected ?ContainerInterface $container = null; | ||
|
|
||
| public function setContainer(?ContainerInterface $container = null): void | ||
| { | ||
| $this->container = $container; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -16,7 +16,7 @@ | |
| use Symfony\Component\HttpFoundation\ParameterBag; | ||
| use Symfony\Component\HttpKernel\Kernel; | ||
|
|
||
| if (Kernel::MAJOR_VERSION >= 6) { | ||
| class Parameters extends ParameterBag | ||
| { | ||
| /** | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -23,7 +23,6 @@ | |
| use Sylius\Resource\Metadata\MetadataInterface; | ||
| use Sylius\Resource\Model\ResourceInterface; | ||
| use Sylius\Resource\ResourceActions; | ||
| use Symfony\Component\DependencyInjection\ContainerInterface; | ||
| use Symfony\Component\HttpFoundation\Request; | ||
| use Symfony\Component\HttpFoundation\Response; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,6 @@ | |
|
|
||
| namespace Sylius\Bundle\ResourceBundle\DependencyInjection\Compiler; | ||
|
|
||
| use Sylius\Bundle\ResourceBundle\DependencyInjection\Compiler\Helper\TargetEntitiesResolverInterface; | ||
| use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface; | ||
| use Symfony\Component\DependencyInjection\ContainerBuilder; | ||
|
|
@@ -47,13 +46,7 @@ public function process(ContainerBuilder $container): void | |
| $resolveTargetEntityListener->addMethodCall('addResolveTargetEntity', [$interface, $model, []]); | ||
| } | ||
|
|
||
| if (!$resolveTargetEntityListener->hasTag('doctrine.event_listener')) { | ||
| $resolveTargetEntityListener->addTag('doctrine.event_listener', ['event' => 'loadClassMetadata']); | ||
| } | ||
| } | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,13 +33,9 @@ public function __construct(RepositoryInterface $repository, ?string $identifier | |
| } | ||
|
|
||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| public function transform(mixed $value): mixed | ||
| { | ||
| if (null === $value) { | ||
| return null; | ||
|
|
@@ -51,8 +47,10 @@ public function transform($value) | |
| return PropertyAccess::createPropertyAccessor()->getValue($value, $this->identifier); | ||
| } | ||
|
|
||
| /** | ||
| * @inheritDoc | ||
| */ | ||
| public function reverseTransform(mixed $value): ?ResourceInterface | ||
| { | ||
| if (null === $value) { | ||
| return null; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -30,7 +30,8 @@ | |
| <service id="sylius.translation.translatable_listener.doctrine.orm" class="Sylius\Bundle\ResourceBundle\EventListener\ORMTranslatableListener"> | ||
| <argument type="service" id="sylius.resource_registry" /> | ||
| <argument type="service" id="sylius.translatable_entity_locale_assigner" /> | ||
| <tag name="doctrine.event_listener" connection="default" event="loadClassMetadata" priority="99" /> | ||
| <tag name="doctrine.event_listener" connection="default" event="postLoad" priority="99" /> | ||
| </service> | ||
| <service id="Sylius\Bundle\ResourceBundle\EventListener\ORMTranslatableListener" alias="sylius.translation.translatable_listener.doctrine.orm" /> | ||
|
|
||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,7 @@ | |
| <argument type="service"> | ||
| <service class="Sylius\Bundle\ResourceBundle\Routing\RouteFactory" /> | ||
| </argument> | ||
| <argument>%kernel.environment%</argument> | ||
| <tag name="routing.loader" /> | ||
| </service> | ||
| <service id="Sylius\Bundle\ResourceBundle\Routing\ResourceLoader" alias="sylius.routing.loader.resource" public="false" /> | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this package still a problem? The newest version supports SF7 if I see correctly.
Ref.: https://packagist.org/packages/willdurand/hateoas-bundle#2.6.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, there is an issue => willdurand/BazingaHateoasBundle#108