This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Font relative paths #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
AliSoftware
reviewed
Aug 17, 2017
There was a problem hiding this comment.
We should (manually) test at some point that paths are correct and fonts are registered properly by using an actual dummy project that would include some Project/FooBrand/Resources/UI/Fonts folder, added as a folder reference, and itself containing subfolders like DarkTheme/Article/MyFont.ttf and look at the bundle structure and what we got once compiled.
Documentation/fonts/swift2.md
Outdated
| @@ -19,6 +19,7 @@ You can customize some elements of this template by overriding the following par | |||
| | Parameter Name | Default Value | Description | | |||
| | -------------- | ------------- | ----------- | | |||
| | `enumName` | `FontFamily` | Allows you to change the name of the generated `enum` containing all font families. | | |||
| | `preservePath` | N/A | Setting this parameter will disable the basename filter applied to all font paths. Use this if you are adding fonts to your target in a specific folder, and need to preserve those folder names when registering fonts. The path will be relative to the folder you provided to SwiftGen. | | |||
There was a problem hiding this comment.
Use this if you added your font folder as a "folder reference" in your Xcode project, making that folder hierarchy preserved once copied in the build app bundle
Documentation/fonts/swift3.md
Outdated
| @@ -18,6 +18,7 @@ You can customize some elements of this template by overriding the following par | |||
| | Parameter Name | Default Value | Description | | |||
| | -------------- | ------------- | ----------- | | |||
| | `enumName` | `FontFamily` | Allows you to change the name of the generated `enum` containing all font families. | | |||
| | `preservePath` | N/A | Setting this parameter will disable the basename filter applied to all font paths. Use this if you are adding fonts to your target in a specific folder, and need to preserve those folder names when registering fonts. The path will be relative to the folder you provided to SwiftGen. | | |||
Documentation/fonts/swift4.md
Outdated
| @@ -18,6 +18,7 @@ You can customize some elements of this template by overriding the following par | |||
| | Parameter Name | Default Value | Description | | |||
| | -------------- | ------------- | ----------- | | |||
| | `enumName` | `FontFamily` | Allows you to change the name of the generated `enum` containing all font families. | | |||
| | `preservePath` | N/A | Setting this parameter will disable the basename filter applied to all font paths. Use this if you are adding fonts to your target in a specific folder, and need to preserve those folder names when registering fonts. The path will be relative to the folder you provided to SwiftGen. | | |||
djbe
force-pushed
the
feature/font-relative-paths
branch
from
a086a7f to
558dab6
Compare
AliSoftware
approved these changes
Aug 17, 2017
| @@ -19,6 +19,7 @@ You can customize some elements of this template by overriding the following par | |||
| | Parameter Name | Default Value | Description | | |||
| | -------------- | ------------- | ----------- | | |||
| | `enumName` | `FontFamily` | Allows you to change the name of the generated `enum` containing all font families. | | |||
| | `preservePath` | N/A | Setting this parameter will disable the basename filter applied to all font paths. Use this if you added your font folder as a "folder reference" in your Xcode project, making that folder hierarchy preserved once copied in the build app bundle. The path will be relative to the folder you provided to SwiftGen. | | |||
djbe
force-pushed
the
feature/font-relative-paths
branch
from
558dab6 to
1439a37
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SwiftGen/SwiftGen#324.
SwiftGenKit related PR: SwiftGen/SwiftGenKit#52
StencilSwiftKit related PR: SwiftGen/StencilSwiftKit#60