This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Font relative paths #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
AliSoftware
reviewed
Aug 16, 2017
Sources/Parsers/FontsParser.swift
Outdated
| @@ -84,6 +84,8 @@ public final class FontsParser: Parser { | |||
|
|
|||
| public func parse(path: Path) { | |||
| let dirChildren = path.iterateChildren(options: [.skipsHiddenFiles, .skipsPackageDescendants]) | |||
| let parentDir = path.absolute().parent() | |||
djbe
force-pushed
the
feature/font-relative-paths
branch
from
a71921b to
c531812
Compare
AliSoftware
approved these changes
Aug 17, 2017
AliSoftware
reviewed
Aug 17, 2017
|
What do you want to test? The |
|
Yeah and also try to call the while framework entry-point with a relative path and an absolute path and check they don't leak the full path in either case, something like that? |
|
(Also reminder: don't forget to wait for SwiftGen/templates#71 then undo the |
|
That was in the templates repo, I already removed the change 👍 |
|
Haha I was actually searching it after I made that comment and failed to find it again and thought I needed some more sleep (which might still be true anyway 😜 ) |
|
Todo: align subrepo before merged |
djbe
force-pushed
the
feature/font-relative-paths
branch
from
bc816fa to
51dec9a
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes SwiftGen/SwiftGen#323.
Refs SwiftGen/SwiftGen#324.
templates related PR: SwiftGen/templates#71