Test file bundles #125
Merged
Test file bundles #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will simplify testing :^)
Priority is per-(direct subclass of)FileLoaderBase -- i.e., each concrete subclass of, say, SoundFileLoader must have a unique priority. See #124 for more context :^)
Turns out that the builtin `mimetypes` module can't detect using anything except file extension, so that's basically useless for us.
This also adds tests from the ftyers/ directory.
Before, we were relying on garbage collection to clean up our temp files, which is probably not tenable long-term.
There needs to be some class sitting between SoundFileLoader and the concrete children since - each child shares a lot of code with siblings - each child needs the `pydub` external library, which may not exist on all systems See #122 for more context.
keggsmurph21
force-pushed
the
test-file-bundles
branch
from
53dc87e to
fca3259
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add tests for
FileBundleandFileBundleList. Stacks on #118 and #122.See #124 for discussion