Test sound files #122
Merged
Test sound files #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
calebho
approved these changes
Dec 31, 2019
keggsmurph21
added a commit
that referenced
this pull request
Dec 31, 2019
There needs to be some class sitting between SoundFileLoader and the concrete children since - each child shares a lot of code with siblings - each child needs the `pydub` external library, which may not exist on all systems See #122 for more context.
keggsmurph21
added a commit
that referenced
this pull request
Dec 31, 2019
There needs to be some class sitting between SoundFileLoader and the concrete children since - each child shares a lot of code with siblings - each child needs the `pydub` external library, which may not exist on all systems See #122 for more context.
keggsmurph21
added a commit
that referenced
this pull request
Dec 31, 2019
There needs to be some class sitting between SoundFileLoader and the concrete children since - each child shares a lot of code with siblings - each child needs the `pydub` external library, which may not exist on all systems See #122 for more context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These patches add support for loading (but not playing back)
.wav,.flac,.ogg, and.mp3files. Unfortunately, there is a lot of code repetition between these classes as they're all basically wrappers around apydub.AudioSegment.However, we need to separate them out into different classes because
pydub, and we don't want to be importing that inbase.py.