-
-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some Tux animation glitches #2810
Fix some Tux animation glitches #2810
Conversation
I tried as best as possible to workaround this. Even though this might occur only very rare, it is worth having a look at it. The growing animation is now finished before turning to stone. Transition from growing to stone is not that smooth, to be honest. Beside this, I noticed some animation glitches when small Tux slides and gains a grow powerup (the hight was adjusted for a small time which led Tux "fly" for a short time), which should be fixed as well. I did several tests, but someone else (@Rusty-Box ?) should definitely do this as well and provide feedback. |
94b2846
to
f1124c5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't test this, but code looks good.
Looks like recent changes on master broke some of this. I need to rework this. |
f1124c5
to
347c545
Compare
Ok, next try. Mentionend points in description should be included now. |
* Wait until the growing animation is finished before changing to stone animation when smallTux gains an earth flower. * Fix animation glitch from sliding to slidegrow
347c545
to
49ea07e
Compare
Fixes #2533