Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slc4 account name #130

Merged
merged 30 commits into from
Nov 10, 2023
Merged

Slc4 account name #130

merged 30 commits into from
Nov 10, 2023

Conversation

g105b
Copy link
Contributor

@g105b g105b commented Nov 10, 2023

No description provided.

g105b and others added 29 commits October 11, 2023 11:01
# Conflicts:
#	class/Product/ProductRepository.php
…ift into slc4

# Conflicts:
#	class/Auth/UserRepository.php
#	class/ServiceLoader.php
#	composer.json
#	composer.lock
…shift into slc4-refactor

# Conflicts:
#	README.md
#	class/Audit/AuditRepository.php
#	class/Auth/UserRepository.php
#	class/Product/ProductRepository.php
#	class/ServiceLoader.php
#	class/Split/SplitRepository.php
#	class/Upload/UploadManager.php
#	composer.json
#	composer.lock
#	page/_common.php
#	page/_component/global-header.html
#	page/_component/splits-list.html
#	page/account/products.php
#	page/account/splits/@split.php
#	page/account/splits/index.php
#	phpmd.xml
#	query/Split/getAll.sql
Copy link

codecov bot commented Nov 10, 2023

Codecov Report

Attention: 266 lines in your changes are missing coverage. Please review.

Comparison is base (44fdfd9) 17.13% compared to head (a6541ec) 16.60%.

❗ Current head a6541ec differs from pull request most recent head fd9730e. Consider uploading reports for the commit fd9730e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #130      +/-   ##
============================================
- Coverage     17.13%   16.60%   -0.53%     
- Complexity      214      222       +8     
============================================
  Files            31       32       +1     
  Lines           823      849      +26     
============================================
  Hits            141      141              
- Misses          682      708      +26     
Files Coverage Δ
class/Audit/AuditRepository.php 2.35% <ø> (ø)
class/Upload/Upload.php 96.55% <ø> (ø)
class/Auth/Settings.php 0.00% <0.00%> (ø)
class/Split/SplitRepository.php 0.00% <0.00%> (ø)
class/Artist/ArtistRepository.php 0.00% <0.00%> (ø)
class/Product/ProductRepository.php 42.64% <0.00%> (ø)
class/ServiceLoader.php 0.00% <0.00%> (ø)
class/Auth/UserRepository.php 3.77% <0.00%> (-1.64%) ⬇️
class/Usage/UsageRepository.php 0.00% <0.00%> (ø)
class/Upload/UploadRepository.php 12.84% <12.84%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…shift into slc4-account-name

# Conflicts:
#	class/Auth/UserRepository.php
#	class/ServiceLoader.php
#	page/account/splits/index.php
@g105b g105b merged commit 78a693a into master Nov 10, 2023
7 checks passed
@g105b g105b deleted the slc4-account-name branch November 10, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants