Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Processor: Tell the user if we can't process their file #62

Open
richardbirkin opened this issue Jan 12, 2023 · 4 comments
Open

Processor: Tell the user if we can't process their file #62

richardbirkin opened this issue Jan 12, 2023 · 4 comments
Assignees
@g105b
Labels
code complete Functionally working, might need design or content writing feature: lovable This increases the love for the product
Milestone
SLC #3 - Profit &...

Comments

@richardbirkin
Copy link
Contributor

If a user uploads a statement that cannot be processed, we need to:

  • let them know that it has failed
  • let them know that we might need to look at it
  • let them give us permission to look at it
  • be clear that this interaction activates an NDA between TrackShift and them, with the onus put on us not sharing any details, not copying or sending any data or compromising it in any way
@g105b g105b added the obsolete label Jul 12, 2023
@richardbirkin
Copy link
Contributor Author

@g105b this relates to what we spoke about earlier

@g105b g105b changed the title Processor Failure Processor: Tell the user if we can't process their file Sep 6, 2023
@richardbirkin richardbirkin added feature: lovable This increases the love for the product and removed feature obsolete labels Sep 6, 2023
@richardbirkin richardbirkin added this to the SLC #2 - Profit & Loss milestone Sep 6, 2023
g105b added a commit that referenced this issue Oct 11, 2023
@g105b
feature: notification when file is not understood
ddbf1e9 
for #62
@g105b
Copy link
Contributor

g105b commented Oct 13, 2023

The flow for this is complete, but I think it could be made to look a bit nicer.

image

When the user uploads something that TS doesn't understand, it'll raise a notification (the bell will turn red).

The notification text would be good to explain that we're working on it blah blah, maybe with a link to a page on the website explaining how we are implementing processors for all types of file. How do you think we should word this?

@g105b g105b added the code complete Functionally working, might need design or content writing label Oct 13, 2023
@richardbirkin
Copy link
Contributor Author

  • TrackShift should email Greg and Biff if a user's upload fails

@richardbirkin
Copy link
Contributor Author

richardbirkin commented Oct 13, 2023 •
edited
Loading

  • new page for the user to read about upload failure

I have created the page upload-fail

slc3-upload-fail-page

g105b added a commit that referenced this issue Nov 10, 2023
@g105b @richardbirkin
WIP: SLC 3 (#115)
1eac6ba 
* docs: move setup guide to wiki

* fix: associate cost to user rather than product

* test: assert unknown uploads

* feature: notification when file is not understood
for #62

* tweak: don't notify for new audits

* wip: split editor UI

* ui: split editor ui

* wip: split classes

* wip: split percentage ui complete

* wip: split percentage ui complete

* test: update qa

* asset: plus minus icons

* feature: splits and profits in product table
closes #105
closes #101

* style: splits list + editor

* bug fix: profit sum

* style: splits list border and margin

* test: assertions for profit/balance

* test: test profit calculations

* ci: wip behat on github actions

---------

Co-authored-by: rjbirkin <[email protected]>
g105b added a commit that referenced this issue Nov 10, 2023
@g105b @richardbirkin
Slc4 refactor (#129)
44fdfd9 
* docs: move setup guide to wiki

* fix: associate cost to user rather than product

* test: assert unknown uploads

* feature: notification when file is not understood
for #62

* tweak: don't notify for new audits

* wip: split editor UI

* ui: split editor ui

* wip: split classes

* wip: split percentage ui complete

* wip: split percentage ui complete

* test: update qa

* asset: plus minus icons

* feature: splits and profits in product table
closes #105
closes #101

* style: splits list + editor

* bug fix: profit sum

* style: splits list border and margin

* test: assertions for profit/balance

* test: test profit calculations

* ci: wip behat on github actions

* wip: authwave

* feature: login via authwave
closes #119

* feature: refactor upload manager

* build: use new releases on all repos

* test: improve tests

---------

Co-authored-by: rjbirkin <[email protected]>
g105b added a commit that referenced this issue Nov 10, 2023
@g105b @richardbirkin
Slc4 account name (#130)
78a693a 
* docs: move setup guide to wiki

* fix: associate cost to user rather than product

* test: assert unknown uploads

* feature: notification when file is not understood
for #62

* tweak: don't notify for new audits

* wip: split editor UI

* ui: split editor ui

* wip: split classes

* wip: split percentage ui complete

* wip: split percentage ui complete

* test: update qa

* asset: plus minus icons

* feature: splits and profits in product table
closes #105
closes #101

* style: splits list + editor

* bug fix: profit sum

* style: splits list border and margin

* test: assertions for profit/balance

* test: test profit calculations

* ci: wip behat on github actions

* wip: authwave

* feature: login via authwave
closes #119

* feature: refactor upload manager

* build: use new releases on all repos

* test: improve tests

* feature: account name - new settings panel
closes #121

---------

Co-authored-by: rjbirkin <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@g105b g105b

Labels
code complete Functionally working, might need design or content writing feature: lovable This increases the love for the product
Projects
None yet
Milestone
SLC #3 - Profit & Loss 2: Splits
Development

No branches or pull requests
2 participants
@g105b @richardbirkin