Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: ElastixRegistrationMethod writes initial transform parameter files #909

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

N-Dekker
Copy link
Member

Let ElastixRegistrationMethod write the transform maps from its InitialTransformParameterObject to the output directory.

Let ElastixRegistrationMethod write the transform maps from its InitialTransformParameterObject to the output directory.
@N-Dekker N-Dekker requested review from mstaring and stefanklein June 13, 2023 15:23
++i;
}

argumentMap["-tp"] = initialTransformParameterFileName;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears sufficient to place the name of the last initial transform parameter file (for example, "InitialTransformParameters.2.txt") in the command-line argument map, entry "-tp". This is picked up by TransformBase<TElastix>::ReadFromFile() at

this->SetTransformParametersFileName(configuration.GetCommandLineArgument("-tp"));

@N-Dekker
Copy link
Member Author

N-Dekker commented Jun 14, 2023

For the sake of time, I'll merge this this afternoon, but you may still have a look afterwards, of course.

FYI, I did locally test that the sequence of transformations that is written this way can be read back in by transformix 👍

@N-Dekker N-Dekker merged commit 9e64269 into main Jun 14, 2023
@N-Dekker N-Dekker deleted the Write-initial-transform-parameter-maps-to-output-dir branch June 14, 2023 13:55
N-Dekker added a commit that referenced this pull request Jun 15, 2023
Follow-up to pull request #909 commit 9e64269 "ENH: ElastixRegistrationMethod writes initial transform parameter files"

Requested by Marius Staring.
N-Dekker added a commit that referenced this pull request Jun 15, 2023
Follow-up to pull request #909 commit 9e64269 "ENH: ElastixRegistrationMethod writes initial transform parameter files"

Requested by Marius Staring.
N-Dekker added a commit that referenced this pull request Jun 15, 2023
Follow-up to pull request #909 commit 9e64269 "ENH: ElastixRegistrationMethod writes initial transform parameter files"

Requested by Marius Staring.
N-Dekker added a commit that referenced this pull request Jun 19, 2023
Follow-up to pull request #909 commit 9e64269 "ENH: ElastixRegistrationMethod writes initial transform parameter files"

Requested by Marius Staring.
N-Dekker added a commit to N-Dekker/ITKElastix that referenced this pull request Jul 19, 2023
Follow-up to InsightSoftwareConsortium#211
commit 1043f10 "ENH: Bump elastix version to
2023-05-15, use C++17"

Including:

  SuperElastix/elastix#936
  SuperElastix/elastix@115d8e1
  ENH: Add `ElastixRegistrationMethod::SetInitialTransform

  SuperElastix/elastix#933
  SuperElastix/elastix@d33a0d5
  BUG: Fix reference count in ConvertItkTransformBaseToSingleItkTransform

  SuperElastix/elastix#924
  SuperElastix/elastix@71a4a9a
  ENH: Add TransformParameterFileName property to TransformixFilter

  SuperElastix/elastix#922
  SuperElastix/elastix@9d76b86
  ENH: Restore ELASTIX_BUILD_EXECUTABLE CMake option

  SuperElastix/elastix#909
  SuperElastix/elastix@9e64269
  ENH: ElastixRegistrationMethod writes initial transform parameter files

  SuperElastix/elastix#903
  SuperElastix/elastix@2170592
  ENH: Remove the letter 's' from "InitialTransformParametersFileName"

  SuperElastix/elastix#898
  SuperElastix/elastix@691c358
  BUG: Add InitialTransformParameterObject maps to registration result
N-Dekker added a commit to N-Dekker/ITKElastix that referenced this pull request Jul 20, 2023
Follow-up to InsightSoftwareConsortium#211
commit 1043f10 "ENH: Bump elastix version to
2023-05-15, use C++17"

Including:

  SuperElastix/elastix#936
  SuperElastix/elastix@115d8e1
  ENH: Add `ElastixRegistrationMethod::SetInitialTransform

  SuperElastix/elastix#933
  SuperElastix/elastix@d33a0d5
  BUG: Fix reference count in ConvertItkTransformBaseToSingleItkTransform

  SuperElastix/elastix#924
  SuperElastix/elastix@71a4a9a
  ENH: Add TransformParameterFileName property to TransformixFilter

  SuperElastix/elastix#922
  SuperElastix/elastix@9d76b86
  ENH: Restore ELASTIX_BUILD_EXECUTABLE CMake option

  SuperElastix/elastix#909
  SuperElastix/elastix@9e64269
  ENH: ElastixRegistrationMethod writes initial transform parameter files

  SuperElastix/elastix#903
  SuperElastix/elastix@2170592
  ENH: Remove the letter 's' from "InitialTransformParametersFileName"

  SuperElastix/elastix#898
  SuperElastix/elastix@691c358
  BUG: Add InitialTransformParameterObject maps to registration result
N-Dekker added a commit to N-Dekker/ITKElastix that referenced this pull request Jul 25, 2023
Follow-up to InsightSoftwareConsortium#211
commit 1043f10 "ENH: Bump elastix version to
2023-05-15, use C++17"

Including:

  SuperElastix/elastix#936
  SuperElastix/elastix@115d8e1
  ENH: Add `ElastixRegistrationMethod::SetInitialTransform

  SuperElastix/elastix#933
  SuperElastix/elastix@d33a0d5
  BUG: Fix reference count in ConvertItkTransformBaseToSingleItkTransform

  SuperElastix/elastix#924
  SuperElastix/elastix@71a4a9a
  ENH: Add TransformParameterFileName property to TransformixFilter

  SuperElastix/elastix#922
  SuperElastix/elastix@9d76b86
  ENH: Restore ELASTIX_BUILD_EXECUTABLE CMake option

  SuperElastix/elastix#909
  SuperElastix/elastix@9e64269
  ENH: ElastixRegistrationMethod writes initial transform parameter files

  SuperElastix/elastix#903
  SuperElastix/elastix@2170592
  ENH: Remove the letter 's' from "InitialTransformParametersFileName"

  SuperElastix/elastix#898
  SuperElastix/elastix@691c358
  BUG: Add InitialTransformParameterObject maps to registration result
N-Dekker added a commit to InsightSoftwareConsortium/ITKElastix that referenced this pull request Jul 25, 2023
Follow-up to #211
commit 1043f10 "ENH: Bump elastix version to
2023-05-15, use C++17"

Including:

  SuperElastix/elastix#936
  SuperElastix/elastix@115d8e1
  ENH: Add `ElastixRegistrationMethod::SetInitialTransform

  SuperElastix/elastix#933
  SuperElastix/elastix@d33a0d5
  BUG: Fix reference count in ConvertItkTransformBaseToSingleItkTransform

  SuperElastix/elastix#924
  SuperElastix/elastix@71a4a9a
  ENH: Add TransformParameterFileName property to TransformixFilter

  SuperElastix/elastix#922
  SuperElastix/elastix@9d76b86
  ENH: Restore ELASTIX_BUILD_EXECUTABLE CMake option

  SuperElastix/elastix#909
  SuperElastix/elastix@9e64269
  ENH: ElastixRegistrationMethod writes initial transform parameter files

  SuperElastix/elastix#903
  SuperElastix/elastix@2170592
  ENH: Remove the letter 's' from "InitialTransformParametersFileName"

  SuperElastix/elastix#898
  SuperElastix/elastix@691c358
  BUG: Add InitialTransformParameterObject maps to registration result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant