STYLE: Declare WriteResultMesh filename parameter std::string

Avoided using a raw, unmanaged char pointer, and avoided the need to write null-handling code.
SuperElastix · Jun 12, 2023 · 007dadd · 007dadd
1 parent f546201
commit 007dadd
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/Components/Metrics/MissingStructurePenalty/elxMissingStructurePenalty.h b/Components/Metrics/MissingStructurePenalty/elxMissingStructurePenalty.h
@@ -162,7 +162,7 @@ class ITK_TEMPLATE_EXPORT MissingStructurePenalty
   ReadMesh(const std::string & meshFileName, typename FixedMeshType::Pointer & mesh);
 
   void
-  WriteResultMesh(const char * filename, MeshIdType meshId);
+  WriteResultMesh(const std::string & filename, MeshIdType meshId);
 
   unsigned int
   ReadTransformixPoints(const std::string & filename, typename MeshType::Pointer & mesh);

diff --git a/Components/Metrics/MissingStructurePenalty/elxMissingStructurePenalty.hxx b/Components/Metrics/MissingStructurePenalty/elxMissingStructurePenalty.hxx
@@ -212,7 +212,7 @@ MissingStructurePenalty<TElastix>::AfterEachIteration()
 
       try
       {
-        this->WriteResultMesh(makeFileName.str().c_str(), meshId);
+        this->WriteResultMesh(makeFileName.str(), meshId);
       }
       catch (const itk::ExceptionObject & excp)
       {
@@ -261,7 +261,7 @@ MissingStructurePenalty<TElastix>::AfterEachResolution()
 
       try
       {
-        this->WriteResultMesh(makeFileName.str().c_str(), meshId);
+        this->WriteResultMesh(makeFileName.str(), meshId);
       }
       catch (const itk::ExceptionObject & excp)
       {
@@ -309,7 +309,7 @@ MissingStructurePenalty<TElastix>::ReadMesh(const std::string & meshFileName, ty
 
 template <class TElastix>
 void
-MissingStructurePenalty<TElastix>::WriteResultMesh(const char * filename, MeshIdType meshId)
+MissingStructurePenalty<TElastix>::WriteResultMesh(const std::string & filename, MeshIdType meshId)
 {
   /** Setup the pipeline. */
 

diff --git a/Components/Metrics/PolydataDummyPenalty/elxPolydataDummyPenalty.h b/Components/Metrics/PolydataDummyPenalty/elxPolydataDummyPenalty.h
@@ -182,7 +182,7 @@ class ITK_TEMPLATE_EXPORT PolydataDummyPenalty
   ReadMesh(const std::string & meshFileName, typename FixedMeshType::Pointer & mesh);
 
   void
-  WriteResultMesh(const char * filename, MeshIdType meshId);
+  WriteResultMesh(const std::string & filename, MeshIdType meshId);
 
   unsigned int
   ReadTransformixPoints(const std::string & filename, typename MeshType::Pointer & mesh);

diff --git a/Components/Metrics/PolydataDummyPenalty/elxPolydataDummyPenalty.hxx b/Components/Metrics/PolydataDummyPenalty/elxPolydataDummyPenalty.hxx
@@ -201,7 +201,7 @@ PolydataDummyPenalty<TElastix>::AfterEachIteration()
 
       try
       {
-        this->WriteResultMesh(makeFileName.str().c_str(), meshId);
+        this->WriteResultMesh(makeFileName.str(), meshId);
       }
       catch (const itk::ExceptionObject & excp)
       {
@@ -250,7 +250,7 @@ PolydataDummyPenalty<TElastix>::AfterEachResolution()
 
       try
       {
-        this->WriteResultMesh(makeFileName.str().c_str(), meshId);
+        this->WriteResultMesh(makeFileName.str(), meshId);
       }
       catch (const itk::ExceptionObject & excp)
       {
@@ -300,7 +300,7 @@ PolydataDummyPenalty<TElastix>::ReadMesh(const std::string & meshFileName, typen
 
 template <class TElastix>
 void
-PolydataDummyPenalty<TElastix>::WriteResultMesh(const char * filename, MeshIdType meshId)
+PolydataDummyPenalty<TElastix>::WriteResultMesh(const std::string & filename, MeshIdType meshId)
 {
   /** Set the points of the latest transformation. */
   const MappedMeshContainerPointer mappedMeshContainer = this->GetModifiableMappedMeshContainer();