Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in valor_core where some true positives weren't being correctly deassigned #740

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Fix bug in valor_core where some true positives weren't being correctly deassigned #740

merged 2 commits into from
Sep 5, 2024

Conversation

ntlind
Copy link
Contributor

@ntlind ntlind commented Sep 4, 2024 •
edited
Loading

Improvements

  • Addresses BUG: Valor Core Detection Incorrectly Assigns True Postives #735 by fixing a bug where the use of .shift() to identify irrelevant true positives (TPs) wouldn't correctly catch all false positives if there was a non-TP wedged in between two TPs
  • Added tests to confirm expected behavior
  • Confirmed that this change didn't impact benchmark runtimes

@ntlind ntlind self-assigned this Sep 4, 2024
@ntlind ntlind added the bug Something isn't working label Sep 4, 2024
@ntlind ntlind merged commit cecf980 into main Sep 5, 2024
14 checks passed
@ntlind ntlind deleted the explore_735 branch September 5, 2024 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czaloom czaloom czaloom approved these changes

@ekorman ekorman Awaiting requested review from ekorman ekorman is a code owner

Assignees

@ntlind ntlind

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntlind @czaloom