Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor object detection in valor_core to improve speed #724

Merged
merged 11 commits into from
Aug 28, 2024
Merged

Conversation

ntlind
Copy link
Contributor

@ntlind ntlind commented Aug 27, 2024

Improvements

  • Add back a faster IOU calculation for axis-aligned bboxes
  • Add pandas[performance] as a dependency. Use @numba.jit to speed-up IOU calculations
  • Replace apply and lambda calls where possible to reduce runtime
  • Move an expected output fixture from _inputs to _outputs

Performance

Base OD evaluation for AnnotationType.Box is down to ~11 seconds on the GH runner (previously ~21), and ~6 seconds locally

@ntlind ntlind requested review from czaloom and ekorman as code owners August 27, 2024 16:14
@ntlind ntlind merged commit dba5246 into main Aug 28, 2024
14 checks passed
@ntlind ntlind deleted the speed_up_od branch August 28, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants