Add ValorClassificationManager
and refactor classification.py
#720
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improvements
classification.py
to do fewer joins and do them farther up the chain, allowing us to store less data inValorClassificationManager
. Results in a ~2 second speedup on all classification benchmarks.ValorClassificationManager
to allow users to add datums sequentially, rather than passing a full listValorClassificationManager
andValorDetectionManager
. Add tests showing users can still pass aPrediction
with an empty list of annotations.conftest
intoconftest_inputs
andconftest_outputs
. Move expected answers out of test files and intoconftest_output.py
metadata
was being counted before the label map was applied, resulting ineval_job.meta["labels"]
being too high for label map evaluations.