Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add test_evaluate_detection_fp to valor_core #718

Merged
merged 4 commits into from
Aug 23, 2024
Merged

Add test_evaluate_detection_fp to valor_core #718

merged 4 commits into from
Aug 23, 2024

Conversation

ntlind
Copy link
Contributor

@ntlind ntlind commented Aug 22, 2024

Improvements

  • Adds Eric's test to valor_core to show that we correctly handle FPs in one known error case

@ntlind ntlind requested review from czaloom and ekorman as code owners August 22, 2024 21:52
@ntlind ntlind self-assigned this Aug 22, 2024
@ntlind ntlind added the bug Something isn't working label Aug 22, 2024
@ntlind ntlind merged commit c542ce4 into main Aug 23, 2024
14 checks passed
@ntlind ntlind deleted the add_valor_core_detection_test branch August 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czaloom czaloom czaloom approved these changes

@ekorman ekorman Awaiting requested review from ekorman ekorman is a code owner

Assignees

@ntlind ntlind

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntlind @czaloom