don't allow commas in model and dataset names #700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
|
the migration file replaces dataset and model names with commas to underscores (and adds enough underscores to guarantee uniqueness). it then updates the model, dataset, and evaluation tables accordingly. here are screenshots of before and after running the migration command on some sample data before: after: |
czaloom
reviewed
Aug 5, 2024
|
|
||
| DROP FUNCTION get_unique_name; | ||
|
|
||
| COMMIT; |
There was a problem hiding this comment.
nit: Im not sure the COMMIT is required since we don't use this elsewhere in the migration files.
There was a problem hiding this comment.
i think you're right, i remvoed it
|
Does the migration run properly without |
not sure but i added an empty |
czaloom
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was causing things like
get_evaluationsto fail since the query params are string separated model names