Allow Retrying of Deletion #664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
ntlind
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
If a deletion job gets cancelled or hits its timeout then an zombie row can be created.
This occurs as the existing dataset and model deletion functions rely on getter/setter functions that filter out rows with
DELETINGstates.From the user perspective this produces a very frustrating response where you get
DatasetAlreadyExistsErrorwhen creating a dataset andDatasetDoesNotExistErrorwhen you try to delete it.Feature Description
Remove reliance on external getter/setter functions in dataset and model deletion methods so that they can be run repeatedly.