Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanded Client Timeout Controls #660

Merged
merged 7 commits into from
Jul 8, 2024
Merged

Expanded Client Timeout Controls #660

merged 7 commits into from
Jul 8, 2024

Conversation

czaloom
Copy link
Collaborator

@czaloom czaloom commented Jul 8, 2024 •
edited
Loading

Changes

  • added timeout controls to all Connection memebers
  • added default timeout of 30s for GET, POST, PUT, DELETE

@czaloom czaloom self-assigned this Jul 8, 2024
@czaloom czaloom marked this pull request as ready for review July 8, 2024 19:23
@czaloom czaloom requested review from ntlind and ekorman as code owners July 8, 2024 19:23
ntlind
ntlind reviewed Jul 8, 2024
View reviewed changes
client/valor/client.py Outdated Show resolved Hide resolved
ntlind
ntlind reviewed Jul 8, 2024
View reviewed changes
client/valor/coretypes.py Outdated Show resolved Hide resolved
@czaloom czaloom merged commit faa43d2 into main Jul 8, 2024
12 checks passed
@czaloom czaloom deleted the czaloom-client-timeout-improvements branch July 8, 2024 21:03
@czaloom czaloom mentioned this pull request Jul 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntlind ntlind ntlind approved these changes

@ekorman ekorman Awaiting requested review from ekorman ekorman is a code owner

Assignees

@czaloom czaloom

Labels
improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@czaloom @ntlind