Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Delete Evaluation Endpoint #627

Merged
merged 5 commits into from
Jun 14, 2024
Merged

Add Delete Evaluation Endpoint #627

merged 5 commits into from
Jun 14, 2024

Conversation

czaloom
Copy link
Collaborator

@czaloom czaloom commented Jun 14, 2024

Changes

  • Added endpoint: DELETE /evaluations/{evaluation_id}

@czaloom czaloom self-assigned this Jun 14, 2024
@czaloom czaloom linked an issue Jun 14, 2024 that may be closed by this pull request
ENH: Add evaluation delete endpoint. #617
Closed
3 tasks
@czaloom czaloom marked this pull request as ready for review June 14, 2024 19:38
@czaloom czaloom requested review from ntlind and ekorman as code owners June 14, 2024 19:38
ntlind
ntlind reviewed Jun 14, 2024
View reviewed changes
api/valor_api/backend/core/evaluation.py
evaluation_id : int
The evaluation identifer.

Raises
Copy link
Contributor

@ntlind ntlind Jun 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove "Raises" or describe what this should raise?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added it in!

@czaloom czaloom merged commit 5eb8235 into main Jun 14, 2024
11 checks passed
@czaloom czaloom deleted the czaloom-evaluation-delete-endpoint branch June 14, 2024 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ntlind ntlind ntlind left review comments

@ekorman ekorman ekorman approved these changes

Assignees

@czaloom czaloom

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ENH: Add evaluation delete endpoint.
3 participants
@czaloom @ekorman @ntlind