have comparisons return bool when both objects are values #611
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when two
Equatable
objects (that are not symbolic but have values) are compared, the result is aBoolean
object instead of an actualbool
. this causes some undesired behavior due to examplebool(Boolean(False)) == True
. and indeedtest_add_prediction
andtest_create_image_dataset_with_detections
were bad tests and actually should have been failing (see their updates)This PR updates the following methods of
Equatable
to return bools when both sides have values:__eq__
__ne__
in_
__gt__
__ge__
__lt__
__le__