Fix external player link streaming server url #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edde746 Can you test this when you have the time and let me know if it's working for you ? |
|
Works |
Thank you ! |
elpiel
reviewed
Nov 20, 2023
| @@ -64,6 +64,7 @@ impl From<(&Stream, Option<&Url>, &Settings)> for ExternalPlayerLink { | |||
| /// | |||
| /// [`StreamingServer::base_url`]: crate::models::streaming_server::StreamingServer::base_url | |||
| fn from((stream, streaming_server_url, settings): (&Stream, Option<&Url>, &Settings)) -> Self { | |||
| let streaming_server_url = streaming_server_url.map(|_| &settings.streaming_server_url); | |||
There was a problem hiding this comment.
Suggested change
| let streaming_server_url = streaming_server_url.map(|_| &settings.streaming_server_url); | |
| // Only if the streaming server is available, make sure to use the settings url | |
| // as it might contain a remote url of the server, | |
| // otherwise, deeplinks will be broken for remote server | |
| let streaming_server_url = streaming_server_url.map(|_| &settings.streaming_server_url); |
tymmesyde
force-pushed
the
fix/external-player-link-streaming-server-url
branch
from
cdacf71
to
2e85612
Compare
elpiel
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #539
Fix Stremio/stremio-web#404
Fix Stremio/stremio-web#431