Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use correct streaming server url #539

Closed

Conversation

edde746
Copy link
Contributor

@edde746 edde746 commented Oct 19, 2023

Fixes (kind of, changes to stremio-core-web are also required) Stremio/stremio-web#404 and (duplicate) Stremio/stremio-web#431.

@edde746
Copy link
Contributor Author

edde746 commented Nov 7, 2023

To hopefully assist with reviewing this quicker, here are the steps to re-create the issue that this solves:

  1. Run the stremio-server in a Docker container
  2. Run the current version of stremio-web
  3. Play a magnet link and click the "Copy stream link" button, it should give you the internal docker IP, something like http://172.17.0.2:11470/... when it's expected to be http://127.0.0.1/... or whatever the user set their streaming server to

You can also test the fixed version with these changes implemented in my fork of stremio-web.

Here is a video showcasing the issue and the fix:

Screen.Recording.2023-11-07.at.15.48.36.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant