Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly 1.22.2-5a6889b: can't select certain objects #2701

Closed
Menno5 opened this issue Sep 28, 2022 · 18 comments
Closed

Weekly 1.22.2-5a6889b: can't select certain objects #2701

Menno5 opened this issue Sep 28, 2022 · 18 comments
Labels
opinion OP thinks something should behave differently
Milestone

Comments

@Menno5
Copy link

Menno5 commented Sep 28, 2022

Expected Behaviour

When clicking a indicated and labeled object, the object gets selected with a box around it and information is shown in the upper left corner

Actual Behaviour

When a indicated and labeled object is clicked, the object is not selected. Instead, the nearest star (if any) is selected.
Not all objects have this: all galaxies are getting selected for example.
Here a few examples that are not clickable/selectable: SH2-170 (Little Rosette Nebula), NGC 7822, Sh2-132 (Lion Nebula), NGC 7423, PK 064+15 1, LBN 742, NGC 1491 (Fossil Footprint Nebula)

This is just a small example. Most SH objects are not clickable

Steps to reproduce

See actual behaviour.

System

  • Stellarium version: 1.22.2-5a6889b Windows 64bit
  • Operating system: Windows 10 22H1
  • Graphics Card: MSI GeForce RTX 2080 Ti Gaming X Trio
@alex-w
Copy link
Member

alex-w commented Sep 28, 2022

Please share your config.ini

@alex-w alex-w added the bug Something likely wrong in the code label Sep 28, 2022
@alex-w alex-w added this to the 1.0 milestone Sep 28, 2022
@Menno5
Copy link
Author

Menno5 commented Sep 28, 2022

As requested, here is the config.ini

config.zip

@alex-w
Copy link
Member

alex-w commented Sep 28, 2022

Sorry, I cannot reproduce the issue on macOS in same version (I tried your and my configs).

P.S. @gzotti @10110111 @worachate001 could you check the issue on your systems?

@alex-w alex-w added state: grading The problem is in process of classification... and removed bug Something likely wrong in the code labels Sep 28, 2022
@worachate001
Copy link
Member

Tested on Windows 10 and Ubuntu 20.04. I cannot reproduce the issue on both machines.

@gzotti
Copy link
Member

gzotti commented Sep 28, 2022

cannot reproduce on Win10 21H2 either. When the nebula icons are switched on (not necessarily visible), the object can be selected. That is, if you have activated the SH2 catalog!

@Menno5
Copy link
Author

Menno5 commented Sep 28, 2022

Tested here again.
Found in Sky And Viewing Option under DSO. Normally I have a Limit Magnitude there. When that box is checked, the objects are not selectable. When I uncheck the box, only than the objects are selectable.
I presume this is caused by the fact that they do not have magnitude data when I check on the upper left? It only mentions moderate, medium, and so on, brightness there.

@gzotti
Copy link
Member

gzotti commented Sep 28, 2022

That's possible. But when I activate limit mag, NGC1491 loses its hint.

@Menno5
Copy link
Author

Menno5 commented Sep 28, 2022

If you mean with hints, the info in the upper left corner: yes.
When limit mag is activated, no hints and not selectable on NGC1491. When limit mag not activated, hints are there and it is selectable.

@gzotti
Copy link
Member

gzotti commented Sep 28, 2022

No, hint=icon. (green square. )

So that means, objects with unknown magnitude are not displayed and not selectable when magnitude limiter is active.

Well, how to deal with that? Handle as mag8 in such case? Or as mag14? How to deal with missing data?

@Menno5
Copy link
Author

Menno5 commented Sep 28, 2022

Ah ok, that's a hint :)
I do know that in the 7 July v0.22.2 build, it did gave a hint with mag limiter active. In this Weekly build not.

@gzotti
Copy link
Member

gzotti commented Sep 28, 2022

I think in July I fixed one problem in this area. Maybe I introduced a new one... For now, disable the limiter.

@alex-w
Copy link
Member

alex-w commented Oct 1, 2022

Is the issue resolved now?

@gzotti
Copy link
Member

gzotti commented Oct 1, 2022

I recommended that for now at least @Menno5 should disable the delimiter.

FYI the last fix in this area was #2563 in mid-August, following a discussion in a German astro forum.
If you don't see a truly working fix within 5 minutes, It can at least be pushed to 1.1. But without data about object magnitude, IMHO we cannot evaluate object magnitude here...

@alex-w alex-w added opinion OP thinks something should behave differently and removed state: grading The problem is in process of classification... labels Oct 1, 2022
@gzotti
Copy link
Member

gzotti commented Oct 1, 2022

The point to keep under observation is the difference of magnitude (pure data item, may be 99 for unknown) and Nebula::getVisibilityLevelByMagnitude() (needed for display/visibility filter decisions; May introduce de-facto false values!)

@alex-w alex-w modified the milestones: 1.0, 1.1 Oct 1, 2022
@Menno5
Copy link
Author

Menno5 commented Oct 4, 2022

I just did see that this got the Opinion tag, so let me clarify :)
Normally I use the magnitude limit setting to show objects that are in range of my scope and camera.
I then am exploring in Stellarium until I see something of interest and zoom in on that. But with the magnitude limit set, some objects without magnitude info, still are showing but no electable. Like NGC1491 which is within reach of my setup. It is showing a hint but it's not selectable for the extra info. In this info is for example also the RA/Dec On Date info if I want to use that for my mount to point to.
For now I have set the magnitude limit to Off and the disadvantage here, is that it's showing now a lot of objects (I have a small f/10 FOV) and have to click each one before I can see if it's doable or not.

As for a solution, a suggestion: add an option under or besides Limit Magnitude where we can check to show Brightest, Moderate and/or Low brightness objects? Because that info is most of the time in the description when there is no magnitude data available. That way a magnitude limit can be used and brightness. For example a limit MAG 14 objects and Moderate brightness.
Of course, when I am the only one (or very few users with me) who used Stellarium this way, it's a non issue :)
But I think I'm not the only one, seeing #2716 where I'm pretty certain it's the same issue.

@gzotti
Copy link
Member

gzotti commented Oct 4, 2022

The fix mentioned above chose an arbitrary fallback mag=12 for all objects with unknown magnitude. If some info about brightness is available elsewhere, consistently, in all cases, of course this could be extended. This is really a matter of a few more if(...)s. Just which existing data can we exploit with which rules?

@alex-w alex-w added the state: published The fix has been published for testing in weekly binary package label Oct 29, 2022
@github-actions
Copy link

Hello @Menno5!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w closed this as completed Oct 31, 2022
@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Oct 31, 2022
@github-actions
Copy link

Hello @Menno5!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
opinion OP thinks something should behave differently
Development

No branches or pull requests

4 participants