Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some DSO are not labeled when magnitude limit is active #2563

Closed
gzotti opened this issue Aug 10, 2022 · 5 comments
Closed

Some DSO are not labeled when magnitude limit is active #2563

gzotti opened this issue Aug 10, 2022 · 5 comments
Assignees
@gzotti
Labels
bug Something likely wrong in the code community Get involved in development! importance: medium A bit annoying, minor miscalculation, but no crash
Milestone
1.0

Comments

@gzotti
Copy link
Member

gzotti commented Aug 10, 2022 •
edited
Loading

Expected Behaviour

All DSO objects are properly labeled if bright enough

Actual Behaviour

Discussed in
https://forum.astronomie.de/threads/stellarium-beschriftung-von-sh2-objekten-nicht-bei-jedem-objekt-sichtbar.328179/

If DSO magnitude limit is active, objects like SH2-101 (Cygnus star cloud) are not labelled.

I assume magnitude is not properly given in the catalog, defaults to 99, and is thus omitted. This no-magnitude case must be solved in a better way.

Steps to reproduce

Activate Sh2 catalog, activate magnitude limit, and see that Sh2-101 is not labelled.

System

  • Stellarium version: 0.22.2
  • Operating system: Windows 10 (should be irrelevant)
  • Graphics Card: (irrelevant)
@gzotti gzotti added bug Something likely wrong in the code state: confirmed A developer can reproduce the issue importance: medium A bit annoying, minor miscalculation, but no crash community Get involved in development! labels Aug 10, 2022
@github-actions
Copy link

This is a good task for the community to participate in the contribution into Stellarium. Who wants to help us?

@github-actions
Copy link

Hello @gzotti! OK, developers can reproduce the issue. Thanks for the report!

@gzotti gzotti closed this as completed in 3541bd4 Aug 16, 2022
@gzotti gzotti added this to the 22.3 milestone Aug 16, 2022
@gzotti gzotti self-assigned this Aug 16, 2022
alex-w pushed a commit that referenced this issue Aug 18, 2022
@gzotti @alex-w
Fix visibility selection of DSO without proper magnitudes (Fix #2563)
5fb9c2a
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

Hello @gzotti! Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w added state: published The fix has been published for testing in weekly binary package and removed state: fixed labels Sep 10, 2022
@github-actions
Copy link

Hello @gzotti!

Please check the fresh version (development snapshot) of Stellarium:
https://github.com/Stellarium/stellarium-data/releases/tag/weekly-snapshot

@alex-w alex-w removed the state: confirmed A developer can reproduce the issue label Sep 17, 2022
@gzotti gzotti mentioned this issue Oct 1, 2022
Closed
@alex-w alex-w removed the state: published The fix has been published for testing in weekly binary package label Oct 1, 2022
@github-actions
Copy link

github-actions bot commented Oct 1, 2022

Hello @gzotti!

Please check the latest stable version of Stellarium:
https://github.com/Stellarium/stellarium/releases/latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gzotti gzotti

Labels
bug Something likely wrong in the code community Get involved in development! importance: medium A bit annoying, minor miscalculation, but no crash
Milestone
1.0
Development

No branches or pull requests
2 participants
@alex-w @gzotti