Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update protobufs #759

Merged
merged 8 commits into from
Oct 24, 2019
Merged

Update protobufs #759

merged 8 commits into from
Oct 24, 2019

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Oct 19, 2019

@codecov
Copy link

codecov bot commented Oct 19, 2019

Codecov Report

Merging #759 into master will increase coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #759      +/-   ##
==========================================
+ Coverage   22.44%   22.62%   +0.18%     
==========================================
  Files          96       94       -2     
  Lines        9674     9379     -295     
  Branches      817      772      -45     
==========================================
- Hits         2171     2122      -49     
+ Misses       7370     7128     -242     
+ Partials      133      129       -4
Impacted Files Coverage Δ
SteamKit2/SteamKit2/Steam/CDNClient.cs 15.72% <ø> (+3.38%) ⬆️
...eamKit2/SteamKit2/Steam/SteamClient/SteamClient.cs 45.5% <ø> (+0.62%) ⬆️
SteamKit2/SteamKit2/Steam/SteamClient/Callbacks.cs 0% <ø> (ø) ⬆️
...team/Handlers/SteamMatchmaking/SteamMatchmaking.cs 3.77% <0%> (ø) ⬆️
...t2/SteamKit2/Steam/Handlers/SteamUser/Callbacks.cs 2.89% <0%> (ø) ⬆️
.../Steam/Handlers/SteamGameServer/SteamGameServer.cs 18.44% <0%> (ø) ⬆️
...dlers/SteamUnifiedMessages/SteamUnifiedMessages.cs 7.76% <0%> (ø) ⬆️
...2/Steam/Handlers/SteamUnifiedMessages/Callbacks.cs 0% <0%> (ø) ⬆️
...t2/SteamKit2/Steam/Handlers/SteamUser/SteamUser.cs 25.61% <0%> (ø) ⬆️
...Kit2/Steam/Handlers/SteamMasterServer/Callbacks.cs 0% <0%> (ø) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d7e81...f75c471. Read the comment docs.

@yaakov-h
Copy link
Member

So server-list-via-CM is dead now?

@xPaw
Copy link
Member Author

xPaw commented Oct 21, 2019

I removed GetServersOfType which means CDNClient.FetchServerListAsync also had to be removed. That method is trivially replaced by ContentServerDirectoryService.LoadAsync, like depot downloader already did: SteamRE/DepotDownloader@c697532

UFSClient also used the server list, I changed it to require a server for now.

EDIT: I looked at steam client, and I don't see UFS server being used. Steam downloads/uploads via the Cloud service, CCloud_BeginHTTPUpload_Response gives you the http url to upload to.

xPaw added 5 commits October 24, 2019 13:56
Steam CM no longer sends you a list of servers, and there is no meaningful ways of getting an ip address for UFS.
@yaakov-h yaakov-h merged commit a5d17a0 into SteamRE:master Oct 24, 2019
@xPaw xPaw deleted the update-protobufs branch June 18, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants