-
Notifications
You must be signed in to change notification settings - Fork 494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove CS server support from CDNClient #725
Conversation
This is a breaking API change:
|
The trailing slash in the URL builder should be user supplied: 200: 404: |
Codecov Report
@@ Coverage Diff @@
## master #725 +/- ##
==========================================
+ Coverage 22.62% 22.63% +<.01%
==========================================
Files 94 94
Lines 9379 9561 +182
Branches 772 805 +33
==========================================
+ Hits 2122 2164 +42
- Misses 7128 7265 +137
- Partials 129 132 +3
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK. Breaking API changes.
Technically it's actually a CDNClient now and not also a CSClient. 😄 |
This will also need corresponding changes to DepotDownloader... I tried to take a look but I'm way in over my head with that. |
@xPaw merge conflict with yourself 😛 |
Rebased and squashed. |
I kept
AuthenticateDepot
and internal dictionaries to track keys and cdn keys for consumers that don't implement their own.FetchServerListAsync
is removed by #759