Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CS server support from CDNClient #725

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Remove CS server support from CDNClient #725

merged 1 commit into from
Oct 24, 2019

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Oct 2, 2019

I kept AuthenticateDepot and internal dictionaries to track keys and cdn keys for consumers that don't implement their own.

FetchServerListAsync is removed by #759

@azuisleet
Copy link
Member

This is a breaking API change:

  • Methods are removed of course
  • The CDNClient previously tracked a currently connected server, but now the new API has the user pass in the Server endpoint

@azuisleet
Copy link
Member

azuisleet commented Oct 2, 2019

The trailing slash in the URL builder should be user supplied:

200:
https://edge.steam-dns.top.comcast.net:443/depot/232256/manifest/6917145573004583473/5?params

404:
https://edge.steam-dns.top.comcast.net:443/depot/232256/manifest/6917145573004583473/5/?params

@codecov
Copy link

codecov bot commented Oct 2, 2019

Codecov Report

Merging #725 into master will increase coverage by <.01%.
The diff coverage is 21.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #725      +/-   ##
==========================================
+ Coverage   22.62%   22.63%   +<.01%     
==========================================
  Files          94       94              
  Lines        9379     9561     +182     
  Branches      772      805      +33     
==========================================
+ Hits         2122     2164      +42     
- Misses       7128     7265     +137     
- Partials      129      132       +3
Impacted Files Coverage Δ
SteamKit2/SteamKit2/Steam/CDNClient.cs 14.57% <21.42%> (-1.16%) ⬇️
...eamKit2/SteamKit2/Steam/SteamClient/SteamClient.cs 44.6% <0%> (-0.9%) ⬇️
SteamKit2/SteamKit2/Steam/SteamClient/Callbacks.cs 0% <0%> (ø) ⬆️
.../Steam/Handlers/SteamNetworking/SteamNetworking.cs
...amKit2/Steam/Handlers/SteamNetworking/Callbacks.cs
SteamKit2/SteamKit2/Steam/UFSClient/UFSClient.cs 7.6% <0%> (ø)
SteamKit2/SteamKit2/Steam/UFSClient/Callbacks.cs 13.95% <0%> (ø)
SteamKit2/SteamKit2/Util/HardwareUtils.cs 27.23% <0%> (+1.87%) ⬆️
SteamKit2/SteamKit2/Util/Utils.cs 28.04% <0%> (+3.04%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5d17a0...358869a. Read the comment docs.

@azuisleet azuisleet self-requested a review October 2, 2019 17:59
Copy link
Member

@azuisleet azuisleet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK. Breaking API changes.

@yaakov-h
Copy link
Member

yaakov-h commented Oct 2, 2019

Technically it's actually a CDNClient now and not also a CSClient. 😄

@yaakov-h
Copy link
Member

yaakov-h commented Oct 3, 2019

This will also need corresponding changes to DepotDownloader... I tried to take a look but I'm way in over my head with that.

@azuisleet azuisleet added this to the 2.3.0 milestone Oct 16, 2019
@yaakov-h
Copy link
Member

@xPaw merge conflict with yourself 😛

@xPaw
Copy link
Member Author

xPaw commented Oct 24, 2019

Rebased and squashed.

@yaakov-h yaakov-h merged commit d904842 into SteamRE:master Oct 24, 2019
@xPaw xPaw deleted the cdnclient-drop-cs branch June 18, 2020 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants