Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for all example scripts #643

Merged
merged 37 commits into from
Mar 17, 2024
Merged

Fixes for all example scripts #643

merged 37 commits into from
Mar 17, 2024

Conversation

hang-yin
Copy link
Contributor

@hang-yin hang-yin commented Mar 12, 2024 •
edited
Loading

With dataset 3a773e40047e7e104a819fe0a9d03622
And with dataset 1.0.0

cremebrule and others added 22 commits February 27, 2024 15:17
@cremebrule
create AbilityDependencies to enable modular per-ability requirements…
ba02454 
…, update sliceable ability to filter based on required object_parts metadata
@cremebrule
fix ability filtering in get_all_object_category_models_with_abilities
e85b0bf
@cremebrule
Merge branch 'fix/adjacency_and_friction' into fix/slicing_requirements
4c4c4dd
@cremebrule
Merge branch 'og-develop' into fix/slicing_requirements
751ca1b
@cremebrule
Merge branch 'og-develop' into fix/slicing_requirements
0aba90f
@hang-yin
fix point navigation demo
dc83ffd
@cgokmen
Merge branch 'og-develop' into fix/slicing_requirements
12b7635
@hang-yin
Merge branch 'fix/slicing_requirements' of https://github.com/Stanfor…
7f2f918 
…dVL/OmniGibson into fix-examples
@hang-yin
Fix GPU dynamics requirements for scenes that don't use it
eeaa194
@hang-yin
Minor fix for ik example
c10fa88
@hang-yin
Minor fix
0e3c2ed
@hang-yin
Fix attachment demo
ae1f021
@hang-yin
Fix dicing demo
abd6c70
@hang-yin
Fix slicing demo
1db80ff
@hang-yin
Fix load object selector demo
0da18e4
@hang-yin
Fix sample kinematics demo
abe2db7
@hang-yin
Fixed particle modifier demo
61e0d27
@hang-yin
Fix IK example
fdd2a8b
@hang-yin
Fix navigation policy demo
2364896
@hang-yin
Fix robot visualizer example - Tiago initial states
17aac84
@hang-yin
Fix on-fire demo with flow emitter layer registry
a913954
@hang-yin
More on robot visualizer and tiago
419a1ab
@hang-yin hang-yin self-assigned this Mar 12, 2024
@cgokmen cgokmen added this to the v1.0.0 milestone Mar 15, 2024
cgokmen
cgokmen approved these changes Mar 16, 2024
View reviewed changes
Copy link
Contributor

@cgokmen cgokmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple quick comments. Also I'm not sure we want this IK example. Why would someone control the robot that way?

omnigibson/examples/robots/all_robots_visualizer.py Outdated Show resolved Hide resolved
omnigibson/examples/robots/advanced/ik_example.py Outdated Show resolved Hide resolved
@cgokmen cgokmen merged commit 93abbea into og-develop Mar 17, 2024
3 of 4 checks passed
@cgokmen cgokmen deleted the fix-examples branch March 17, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cgokmen cgokmen cgokmen approved these changes

@cremebrule cremebrule Awaiting requested review from cremebrule

@ChengshuLi ChengshuLi Awaiting requested review from ChengshuLi

Assignees

@hang-yin hang-yin

Labels
None yet
Projects
None yet
Milestone
v1.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@hang-yin @cgokmen @cremebrule