Add assisted grasp information to simulator state saving and restoring #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
misoshiruseijin
commented
Sep 22, 2023
misoshiruseijin
commented
- Add AG state to simulator save and restore AG joint when restoring
- Resolved datatype mismatch when restoring Tiago from JSON
…en restoring Tiago from json
ChengshuLi
reviewed
Sep 25, 2023
|
I have made the suggested changes and pushed. Thank you! |
ChengshuLi
approved these changes
Sep 27, 2023
There was a problem hiding this comment.
@cremebrule Would you mind taking a quick look at this PR as well? LGTM.
|
@cremebrule Could you take brief look at this PR and merge it if you think it looks good? I already reviewed it. |
|
I'm going to merge this now to avoid conflicts with the other PR which also does stuff with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.