Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement proper locale check #60

Merged

Conversation

arkadiuszbachorski
Copy link
Collaborator

Implement proper locale check

♻️ Current situation & Problem

Closes #20

⚙️ Release Notes

  • Implement proper locale check

Code of Conduct & Contributing Guidelines

By submitting creating this pull request, you agree to follow our Code of Conduct and Contributing Guidelines:

Copy link

codecov bot commented Oct 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.13%. Comparing base (bdcc14c) to head (56a7cc0).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   24.72%   25.13%   +0.41%     
==========================================
  Files         213      214       +1     
  Lines        7327     7356      +29     
  Branches      340      352      +12     
==========================================
+ Hits         1811     1848      +37     
+ Misses       5394     5387       -7     
+ Partials      122      121       -1     
Files with missing lines Coverage Δ
modules/firebase/localizedText.ts 100.00% <100.00%> (+100.00%) ⬆️
packages/design-system/src/utils/navigator.ts 100.00% <100.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bdcc14c...56a7cc0. Read the comment docs.

@arkadiuszbachorski arkadiuszbachorski merged commit 1a8cd56 into main Oct 8, 2024
10 checks passed
@arkadiuszbachorski arkadiuszbachorski deleted the arek/implement-proper-locale-check-mechanism branch October 8, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement proper locale check mechanism
1 participant