Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proper locale check mechanism #20

Closed
1 task done
arkadiuszbachorski opened this issue Aug 6, 2024 · 0 comments · Fixed by #60
Closed
1 task done

Implement proper locale check mechanism #20

arkadiuszbachorski opened this issue Aug 6, 2024 · 0 comments · Fixed by #60
Labels
enhancement New feature or request

Comments

@arkadiuszbachorski
Copy link
Collaborator

arkadiuszbachorski commented Aug 6, 2024 •
edited
Loading

Problem

ENGAGE-HF-Web-Frontend/modules/firebase/localizedText.ts

Lines 13 to 14 in 4d6858c

export const parseLocalizedText = (text: LocalizedText) =>
isObject(text) ? text[locale] : text

There is no proper locale check yet.

Solution

Implement prop locale check for parsing localized text.

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct and Contributing Guidelines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement proper locale check StanfordBDHG/ENGAGE-HF-Web-Frontend
1 participant
@arkadiuszbachorski