common: Should we sanitize enum names? #3656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves issues where mods add enum entries with names that are not valid resource locations
|
I've taken a hard stance in API 8+ on mods adding stuff like this without valid names. However, this has been made a registry by us. Per Vanilla spec...there is no spec. We're adding it. So therefore, someone could snap back on us and state we're overstepping if we ask them on an issue to fix their name. Therefore, if it is an Enum value which isn't in a registry by Vanilla, we will sanitize the name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves issues where mods add enum entries with names that are not valid resource locations
Are cases where there are enum entries differing only by case a concern we have?
Should other registries be converted?