Conflict between SpongeForge and Infernal Expansion

[Rykita]

Affected Product(s)

SpongeForge

Version

1.16.5-36.2.5-8.0.0-RC1100

Operating System

Linux

Java Version

openjdk version "1.8.0_312"

Plugins/Mods

Infernal Expansion

Describe the bug

[22:23:53] [Server thread/FATAL] [mixin/]: Mixin apply failed infernal-expansion.mixins.json:common.MixinPlayerInteractionManager ->
 net.minecraft.server.management.PlayerInteractionManager: org.spongepowered.asm.mixin.injection.throwables.InvalidInjectionException
  @At("INVOKE") on net/minecraft/server/management/PlayerInteractionManager::IE_firePostRightClickBlockEventServer with priority 1000 cannot
  inject into
  net/minecraft/server/management/PlayerInteractionManager::func_219441_a(Lnet/minecraft/entity/player/ServerPlayerEntity;Lnet/minecraft/world
  /World;Lnet/minecraft/item/ItemStack;Lnet/minecraft/util/Hand;Lnet/minecraft/util/math/BlockRayTraceResult;)Lnet/minecraft/util/ActionResultType; 
  merged by org.spongepowered.common.mixin.tracker.server.level.ServerPlayerGameModeMixin_Tracker with priority 1102 [PREINJECT Applicator Phase -> 
  infernal-expansion.mixins.json:common.MixinPlayerInteractionManager -> Prepare Injections ->  -> 
  handler$zoo000$IE_firePostRightClickBlockEventServer(Lnet/minecraft/entity/player/ServerPlayerEntity;Lnet/minecraft/world
  /World;Lnet/minecraft/item/ItemStack;Lnet/minecraft/util/Hand;Lnet/minecraft/util/math/BlockRayTraceResult;
  Lorg/spongepowered/asm/mixin/injection/callback/CallbackInfoReturnable;)V -> Prepare]

Link to logs

No response

[zml2008]

For some extra context, this issue is encountered after running a build of #3656, which works around an issue with Infernal Expansion's additions to the MobCategory enum.

The relevant Mixin on IE's side: https://github.com/infernalexp/Infernal-Expansion/blob/8d518702601726506b01dd7624c28cd1725f6736/src/main/java/org/infernalstudios/infernalexp/mixin/common/MixinPlayerInteractionManager.java#L36

On our side:

Sponge/src/mixins/java/org/spongepowered/common/mixin/tracker/server/level/ServerPlayerGameModeMixin_Tracker.java

Line 95 in 4a026b6

public InteractionResult useItemOn(final ServerPlayer playerIn, final Level worldIn, final ItemStack stackIn, final InteractionHand handIn, final BlockHitResult blockRaytraceResultIn) {

The injection point IE uses is still present in our overwrite -- would a possible solution be to adjust the priority of our mixin sets to allow IE's injection to occur on top of our overwrite?

[gabizou]

Opened a PR to test it out: #3658

Give this build a try: https://github.com/SpongePowered/Sponge/suites/5780075464/artifacts/192657304

[Enterprise12nx01]

Is there a working spongeforge version for this?

[ImMorpheus]

Hey! You seem to be running an unsupported version (API 8) of SpongeAPI. Support for API 8 ended in October 2023.

API-8 is now end-of-life. We will not be issuing any more API updates for version 8 of our API¹

As part of our legacy cleanup we are closing issues relating to API8/1.16

---

If you wish to move this forward, please try to reproduce the issue on a supported version of Sponge.

Footnotes

1. https://forums.spongepowered.org/t/sponge-status-update-17th-october-2023/42212#spongeapi-82-1 ↩