Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JOSS paper #387
JOSS paper #387
Changes from 42 commits
3e4167e
10a2701
de7c467
bb4b899
9bfea3d
c526171
fd58298
2c59a8b
cd11fd4
4049518
553bcc6
0ebc3aa
e6d56b6
7ef34ce
c6e659a
41cc8ae
e954def
2f61224
e9ac229
8e27e26
ce36c82
66b7b88
afe4feb
1e636df
dc0f903
ba2244c
453a8c1
78d3a46
783522b
8c99caf
6bf1982
9857a80
794ae95
559ca64
61f4850
fc75789
02fe3a0
8615235
f2b6f7d
40887ef
039d756
9000d60
707053b
5e57d9e
30b51ea
2d599b5
767b785
9bde536
71a9355
4ede4da
9fe4f94
7cb917c
4d7702f
f083a9a
2ef9b0f
84239c8
66cf01c
aedac51
465edc7
fd03c79
a8235e1
752e001
5d9c304
c63b33b
19168b6
bcb8df9
5672dd8
684eb5a
d9004fe
5a4e5a4
d4e5125
b1c1062
e81500e
f7e864e
f09bab1
aa93655
eee6555
75e72ce
0018b19
67eddb7
579c490
04a9378
4dc8fa9
81eedda
3e863bc
65c3259
d76df12
a88f020
58d582b
f40d6ce
99e1e26
cc28a4a
f54e7d4
9813e99
000c992
a71fa34
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought you had problem with half precision etc. Is this actually working? Else rephrase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where do I say this is running in half precision? The FFT will switch between FFTW and GenericFFT depending on the format, using half precision is a precision issue not a compiler issue anymore. Other formats like posits may require certain methods that I haven't defined yet, but that's not a problem of SpeedyWeather.