Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increment counter for failed sync #450

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Increment counter for failed sync #450

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions cmd/azure-keyvault-controller/controller/azureKeyVaultSecret.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ func (c *Controller) initAzureKeyVaultSecret() {
akvs, err := convertToAzureKeyVaultSecret(obj)
if err != nil {
klog.ErrorS(err, "failed to convert to azurekeyvaultsecret")
syncFailures.WithLabelValues("add", "AzureKeyVaultSecret").Inc()
return
}

Expand All @@ -55,12 +56,14 @@ func (c *Controller) initAzureKeyVaultSecret() {
newAkvs, err := convertToAzureKeyVaultSecret(new)
if err != nil {
klog.ErrorS(err, "failed to convert to azurekeyvaultsecret")
syncFailures.WithLabelValues("update", "AzureKeyVault").Inc()
return
}

oldAkvs, err := convertToAzureKeyVaultSecret(old)
if err != nil {
klog.ErrorS(err, "failed to convert to azurekeyvaultsecret")
syncFailures.WithLabelValues("update", "AzureKeyVault").Inc()
return
}

Expand All @@ -82,6 +85,7 @@ func (c *Controller) initAzureKeyVaultSecret() {
akvs, err := convertToAzureKeyVaultSecret(obj)
if err != nil {
klog.ErrorS(err, "failed to convert to azurekeyvaultsecret")
syncFailures.WithLabelValues("delete", "AzureKeyVaultSecret").Inc()
return
}

Expand All @@ -93,6 +97,7 @@ func (c *Controller) initAzureKeyVaultSecret() {
err = c.deleteKubernetesValues(akvs)
if err != nil {
klog.ErrorS(err, "failed to delete secret data from azurekeyvaultsecret", "azurekeyvaultsecret", klog.KObj(akvs))
syncFailures.WithLabelValues("delete", "AzureKeyVaultSecret").Inc()
}

// Getting default key to remove from Azure work queue
Expand Down