Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increment counter for failed sync #450

Merged
merged 1 commit into from
Dec 28, 2022
Merged

Increment counter for failed sync #450

merged 1 commit into from
Dec 28, 2022

Conversation

timbuchinger
Copy link
Contributor

This PR resolves #328 by incrementing the failure counter on sync failures.

181192
181192 approved these changes Dec 28, 2022
View reviewed changes
Copy link
Collaborator

@181192 181192 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@timbuchinger Beautiful, thank you! 😄

@181192 181192 merged commit 5b1cc1b into SparebankenVest:master Dec 28, 2022
@181192
Copy link
Collaborator

181192 commented Dec 28, 2022

FYI, Available in beta release version 1.5.0-beta.1

@sdwerwed
Copy link
Contributor

sdwerwed commented Apr 14, 2023 •
edited
Loading

Hey @181192 tested helm chart with image tag 1.5.0-beta.1 and 1.5.0-beta.5 and still can not see the akv2k8s_syncs_failed_total neither promhttp_metric_handler_requests_total{code="404"} in metrics. In logs I get this error RESPONSE 404: 404 Not Found ERROR CODE: SecretNotFound and in metrics its not visible. Should I open a new bug ticket?

@sdwerwed sdwerwed mentioned this pull request Apr 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@181192 181192 181192 approved these changes

@torresdal torresdal Awaiting requested review from torresdal torresdal is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] no metrics for akv2k8s_syncs_failed_total
3 participants
@timbuchinger @181192 @sdwerwed