Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IE9. #251

Closed
wants to merge 7 commits into from
Closed

Support IE9. #251

wants to merge 7 commits into from

Conversation

yoshi6jp
Copy link

bug fixed #34.

tested IE9 on windows 7.

selectstart event is fired after mousedown event in IE9. Therefore fixed dragEl condition.
dragDrop method is synchronous. therefore fixed after dragDrop method.

@yoshi6jp yoshi6jp mentioned this pull request Jan 29, 2015
@RubaXa
Copy link
Collaborator

RubaXa commented Jan 29, 2015

Thank U. Over the weekend, I try to review your PR.

@Pickra
Copy link

Pickra commented Jan 30, 2015

Great job @yoshi6jp 👍
It's working for me and I really needed this fix!
The only comment I would make is:
at line 85 of ng-sortable

you might want to:

if (removed) { items.splice(newIndex, 0, removed); }

Which will help when you want to have this kind of functionality. Which gets messed up when removed === undefined.

@RubaXa RubaXa changed the title Support ie9 Support IE9. Jan 31, 2015
@RubaXa
Copy link
Collaborator

RubaXa commented Feb 2, 2015

Has not been able to check PR, my VirtualBox does not work.

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 2, 2015

I cannot approve this PR, because it simply does not work:

I think there is not need native implementation, it is enough to use the touch-fallback.

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 2, 2015

Create a branch with support for IE9, through touch-fallback, need testing ;]
https://github.com/RubaXa/Sortable/tree/old-browser

@yoshi6jp
Copy link
Author

yoshi6jp commented Feb 4, 2015

I tested IE9 on Win7. (branch: old-browser)
I think that _off mousemove event is necessary.

RubaXa added a commit that referenced this pull request Feb 6, 2015
@RubaXa
Copy link
Collaborator

RubaXa commented Feb 6, 2015

Done.

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 10, 2015

@RubaXa RubaXa closed this Feb 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants