Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sortable doesn't work on IE9 #34

Closed
kevin-smets opened this issue Mar 24, 2014 · 13 comments
Closed

Sortable doesn't work on IE9 #34

kevin-smets opened this issue Mar 24, 2014 · 13 comments
Labels
enhancement Quality of life changes to existing features help wanted
Milestone

Comments

@kevin-smets
Copy link

Just tested on http://rubaxa.github.io/Sortable/

For some reason, all I seem to be able to do is select text, which is weird because I see you disable user.select. It did work once, but not properly, the other items did not rearrange and I was only able to move the draggable one position. It also logged '''LOG: onUpdate.foo:[object HTMLLIElement]''' but after that I had no more success.

I also tried v1.8 and v1.5 on jsfiddle but with the same results.

IE9 is supported right? It has partial support on caniuse and I see that in your code you explicitly declare things for IE9. Thanks!

//edit: weirdly, the images in the "multi" section appear to work properly, however, no draggable is visible.

@RubaXa
Copy link
Collaborator

RubaXa commented Mar 24, 2014

Attempts to make IE9 support were, but I honestly say do not know how it ended.
P.S. As I wrote, I needed only modern browsers.

@kevin-smets
Copy link
Author

Alright, thanks for the feedback. Weird thing is, native drag and drop works on IE9, no? -> http://html5demos.com/drag

Either way (offtopic, just FYI), I've reverted to a full on javascript sortable instead of native drag and drop with fallback. You can control both the clone (active drag element) and the original element, something that's not possible with native html5 so it seems? (plus it's really cross platform, oldIE / modern desktop browsers / touch devices).

Also, when the DOM gets rather heavy, we started to see flashes using the display none / block on the draggable. So now we use ''''pointer-events: none'''' on the draggable element to get the correct elementByPosition. This works a bit better imho, especially on mobile devices (with fallback when pointer events are not supported).

@RubaXa
Copy link
Collaborator

RubaXa commented Apr 17, 2014

Hmm, must try.

@wbond
Copy link

wbond commented Sep 9, 2014

I was able to get sortable to work in IE9 when the handle was an IMG, but not when it was a SPAN. I'm digging a little more to see if I can figure out a work-around.

@wbond
Copy link

wbond commented Sep 9, 2014

I messed around with this for a while, and it seems the way to get it to work in IE9 is to use an IMG or A tag for the handle. Unfortunately with all of my testing, IE9's dragDrop() method always seems to return false if the handle is a SPAN tag.

@RubaXa
Copy link
Collaborator

RubaXa commented Sep 10, 2014

Ruefully.

@fiznool
Copy link

fiznool commented Sep 29, 2014

@wbond I created a plunker to try and verify the behaviour but I can't even get anchors to work (imgs are fine as you suggest).

http://plnkr.co/edit/maW4ZEAcOoaZwL5Hi951?p=preview

(IE9 doesn't work if you click that link above, you need to use the embedded version http://run.plnkr.co/WXWwh2YHArzJ5ucl/).

@billsliu
Copy link

You did a great job, thanks a lot. But IE 9 is not working in your sortable. I search website and found one that works in IE 9.

https://github.com/voidberg/html5sortable New and updated
http://farhadi.ir/posts/the-story-behind-html5-sortable/ Original but abandoned

It is very simple and clean sortable plugin, it is only 140 lines, but it does not work for mobile device.
My javascript skill is not good, I could not combine these two js and make a perfect one. It may help you because you are expert on javascript.

Here is a simple example, I reduce html.sortable.js to 90 lines.
http://www.clubclouds.com/sandbox/Sortable/html5sortable/examples/examples.html

@yankeeinlondon
Copy link

+1 on combining html5sortable with this repo's mobile/touch support

@RubaXa
Copy link
Collaborator

RubaXa commented Nov 12, 2014

Friends, I hope to find a «good man» who will be able to add support for IE9, but it can be seen very few people need it.

@yoshi6jp
Copy link

support for IE9.

yoshi6jp@c2ff228#diff-a8f06fcf61e5b94cb2e81ac878a55678
yoshi6jp@255d2b0#diff-a8f06fcf61e5b94cb2e81ac878a55678

jsFiddle sample

  • (fixed code)[http://jsfiddle.net/yoshi6jp/3boo6hj3/1/]
  • (master code)[http://jsfiddle.net/yoshi6jp/3boo6hj3/]

@renholm
Copy link

renholm commented Jan 9, 2015

@yoshi6jp looks to work except for the selection that is made when one drag an item. But maybe that is possible to disable by CSS or similar. Maybe you should create a Pull-request for more in-depth testing?

This was referenced Jan 27, 2015
@RubaXa
Copy link
Collaborator

RubaXa commented Feb 6, 2015

Try old-browser-branch.

@RubaXa RubaXa closed this as completed Feb 6, 2015
@RubaXa RubaXa added the enhancement Quality of life changes to existing features label Feb 6, 2015
@RubaXa RubaXa added this to the v1.1.0 milestone Feb 11, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Quality of life changes to existing features help wanted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

8 participants