Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.5.0: Pulled items are still remaining in the DOM tree #1046

Closed
cheton opened this issue Feb 22, 2017 · 3 comments
Closed

v1.5.0: Pulled items are still remaining in the DOM tree #1046

cheton opened this issue Feb 22, 2017 · 3 comments

Comments

@cheton
Copy link

cheton commented Feb 22, 2017

I encountered an issue after upgrading from 1.5.0-rc1 to 1.5.0. The pulled items are still remaining in the DOM tree. May I know if this is a breaking change or a bug fix side effect in 1.5.0? Thanks.

You can see below for my configuration and test result:

Configuration

Left
{
  group: {
    name: 'sortable-group',
    pull: true,
    put: false
  }
}
Right
{
  group: {
    name: 'sortable-group',
    pull: false,
    put: true
  }
}

Initial state

image

Drag Apple and Banana from left to right

image

1.5.0-rc1

image

1.5.0

The pulled items are still remaining in the DOM tree.

image

@RubaXa
Copy link
Collaborator

RubaXa commented Feb 22, 2017

Try master

RubaXa added a commit that referenced this issue Feb 22, 2017
@cheton
Copy link
Author

cheton commented Feb 23, 2017

The master branch works great. Thank you for your prompt assistance.

Will there be a newer version published in a few days?

@cheton cheton closed this as completed Feb 23, 2017
RubaXa added a commit that referenced this issue Feb 24, 2017
@RubaXa
Copy link
Collaborator

RubaXa commented Feb 24, 2017

Done -> v1.5.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants