Controlled Component Not Deleting Dragged Item

[thewebsitedev]

Hi there,

I just tried the example on my local machine and the controlled component does not seem to work. The dragged item gets added back to the original list.

Sortable JS - 1.5.0
React Sortable JS - 1.3.0

[thewebsitedev]

Okay, I just uninstalled sortable 1.5.0 and installed 1.5.0-rc1. Now it works fine! But why it won't work with latest release? :(

[cheton]

Thank you for reporting this issue. I will try to find out what made differences between 1.5.0-rc1 and 1.5.0.

[cheton]

I tested the uncontrolled component example and found some changes between 1.5.0-rc1 and 1.5.0. The pulled items still remained in the DOM tree. I will create an issue there to clarify if this is a breaking change or bug.

Configuration

Left

{
  group: {
    name: 'clone1',
    pull: true,
    put: false
  }
}

Right

{
  group: {
    name: 'clone1',
    pull: false,
    put: true
  }
}

Drag Apple and Banana from left to right

1.5.0-rc1

1.5.0

The pull items are still remaining in the DOM tree.

[cheton]

See SortableJS/Sortable#1046

[thewebsitedev]

Awesome! Hope it gets fixed soon.

[cheton]

It's been fixed in its master branch. Please still stay with 1.5.0-rc1 before a newer version of Sortable.js being published.

[cheton]

sortablejs 1.5.1 contains the bug fix of this issue.

[thewebsitedev]

Cool, thanks!